Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: fix statement bundle recreate with non-default schema #91099

Closed
yuzefovich opened this issue Nov 1, 2022 · 0 comments · Fixed by #91245
Closed

sql: fix statement bundle recreate with non-default schema #91099

yuzefovich opened this issue Nov 1, 2022 · 0 comments · Fixed by #91245
Assignees
@yuzefovich
Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. E-quick-win Likely to be a quick win for someone experienced. T-sql-queries SQL Queries Team

Comments

@yuzefovich
Copy link
Member

yuzefovich commented Nov 1, 2022 •
edited
Loading

Currently, if a statement bundle is collected while using a non-default db, we won't be able to recreate it via debug statement-bundle recreate without manually modifying the schema (and possibly the statement). This is the case because we put fully-qualified table names into schema.sql, yet we don't recreate the database nor the schema of those objects. We could either teach the recreate command to handle such errors, or (which is better) include the SQL statements to create the necessary objects into schema.sql right away.

Jira issue: CRDB-21105
@yuzefovich yuzefovich added C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. E-quick-win Likely to be a quick win for someone experienced. labels Nov 1, 2022
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Nov 1, 2022
@yuzefovich yuzefovich changed the title sql: fix statement bundle recreate with non-default db sql: fix statement bundle recreate with non-default schema Nov 3, 2022
@yuzefovich yuzefovich self-assigned this Nov 3, 2022
@yuzefovich yuzefovich mentioned this issue Nov 3, 2022
Merged
@craig craig bot closed this as completed in c57b340 Nov 4, 2022
This was referenced Nov 4, 2022
Merged
Merged
@mgartner mgartner moved this to Done in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuzefovich yuzefovich

Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. E-quick-win Likely to be a quick win for someone experienced. T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: include all schemas into schema.sql in the bundle yuzefovich/cockroach
1 participant
@yuzefovich