Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admission: intra-tenant inter-{database,workload} performance isolation #90299

Open
irfansharif opened this issue Oct 20, 2022 · 0 comments
Open
Labels
A-admission-control C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-admission-control Admission Control

Comments

@irfansharif
Copy link
Contributor

irfansharif commented Oct 20, 2022

Is your feature request related to a problem? Please describe.

AC tries to provide performance isolation across tenants by maintaining per-tenant work in individual work queues and prioritization of work only within a work queue. There's nothing special about the tenant boundary as far as AC is concerned; the tenant ID is treated opaquely as the thing we partition work queues by. This issue tracks prototyping a version of this where instead we segment by an ID derived from in-tenant SQL state, like the database/workload/application name. It's common in SaaS applications to effectively implement multi-tenant along database boundaries where we'd want to provide performance isolation between databases/workloads. Likely depends on fixing #85471.

Additional context

#89721 is a test we’re taking over/nursing back to health. We also expect to add many more variants of it with mixed-workloads across mixed tenants (as part of #89208). We mention it because it’ll teach us (or me at least) how effective we are today at providing performance isolation across tenant boundaries. If we were to do intra-tenant performance isolation like described above, these learnings will apply as well.

Jira issue: CRDB-20681

@irfansharif irfansharif added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-admission-control labels Oct 20, 2022
@irfansharif irfansharif changed the title admission: performance isolation within tenant, between databases/workloads admission: intra-tenant performance isolation across databases/workloads Oct 20, 2022
@irfansharif irfansharif changed the title admission: intra-tenant performance isolation across databases/workloads admission: intra-tenant inter-{database,workload} performance isolation Oct 20, 2022
@nicktrav nicktrav added the T-admission-control Admission Control label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-admission-control C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-admission-control Admission Control
Projects
None yet
Development

No branches or pull requests

2 participants