Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: tests in the package time out under race #87307

Closed
yuzefovich opened this issue Sep 1, 2022 · 5 comments
Closed

sql: tests in the package time out under race #87307

yuzefovich opened this issue Sep 1, 2022 · 5 comments
Assignees
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@yuzefovich
Copy link
Member

yuzefovich commented Sep 1, 2022

Build

=== RUN   TestVisibilityDuringPrimaryKeyChange
    test_log_scope.go:161: test logs captured to: /artifacts/tmp/_tmp/b287de7194e17a0386ee1775f0d198ba/logTestVisibilityDuringPrimaryKeyChange1273361120
    test_log_scope.go:79: use -show-logs to present logs inline
panic: test timed out after 59m55s

Jira issue: CRDB-19264

@yuzefovich yuzefovich added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Sep 1, 2022
@blathers-crl blathers-crl bot added the T-sql-schema-deprecated Use T-sql-foundations instead label Sep 1, 2022
@postamar postamar assigned Xiang-Gu and unassigned fqazi Sep 6, 2022
@Xiang-Gu
Copy link
Contributor

Xiang-Gu commented Sep 6, 2022

@yuzefovich Hi Yahor, do you know how I might be able reproduce this issue?

I ran this test on Master with --stress --race for over an hour and over 3000 runs but still didn't catch it.

@yuzefovich
Copy link
Member Author

Interesting. Maybe the problem is that it takes longer than an hour to run all tests in sql package together? It seems likely given that there are only two goroutines that have been running for more than minute in the dump.

@yuzefovich
Copy link
Member Author

Indeed, I think it's the sql package timing out under race - I saw another timeout here, and it stopped on a different test, after TestVisibilityDuringPrimaryKeyChange completed.

@yuzefovich
Copy link
Member Author

It seems like it's the time to break up at least the tests in sql package, but in the mean time I asked whether we can increase the timeout.

@yuzefovich yuzefovich changed the title sql: TestVisibilityDuringPrimaryKeyChange timed out under race sql: tests in the package time out under race Sep 7, 2022
@yuzefovich
Copy link
Member Author

Should be fixed by #87474.

@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Development

No branches or pull requests

3 participants