Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backupccl: run table BACKUP/RESTORE in sql/schemachanger/sctest/cumulative.go Backup tests #86835

Closed
msbutler opened this issue Aug 24, 2022 · 3 comments · Fixed by #87316
Closed

backupccl: run table BACKUP/RESTORE in sql/schemachanger/sctest/cumulative.go Backup tests #86835

msbutler opened this issue Aug 24, 2022 · 3 comments · Fixed by #87316
Assignees
@Xiang-Gu
Labels
A-disaster-recovery branch-master Failures and bugs on the master branch. C-investigation Further steps needed to qualify. C-label will change. GA-blocker stability-period-v22.2 T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@msbutler
Copy link
Collaborator

msbutler commented Aug 24, 2022 •
edited
Loading

The Backup test in cumulative.go tests that the schema changer can handle being backed up and restored correctly., but it only covers Database/Cluster backups. Table backups should also be covered. This work should be done with the schema team.

Jira issue: CRDB-18953
@msbutler msbutler added C-investigation Further steps needed to qualify. C-label will change. A-disaster-recovery T-disaster-recovery stability-period Intended to be worked on during a stability period. Use with the Milestone field to specify version. labels Aug 24, 2022
@msbutler msbutler self-assigned this Aug 24, 2022
@blathers-crl
Copy link

blathers-crl bot commented Aug 24, 2022

cc @cockroachdb/bulk-io

@msbutler msbutler removed their assignment Aug 25, 2022
@msbutler msbutler added the T-sql-schema-deprecated Use T-sql-foundations instead label Aug 25, 2022
@msbutler msbutler changed the title backupccl: increase test coverage of Backup/Restore of Tables backupccl: run table BACKUP/RESTORE in sql/schemachanger/sctest/cumulative.go Backup tests Aug 25, 2022
@blathers-crl
Copy link

blathers-crl bot commented Aug 30, 2022

Hi @postamar, please add branch-* labels to identify which branch(es) this release-blocker affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@postamar postamar added the branch-master Failures and bugs on the master branch. label Aug 30, 2022
@ajwerner
Copy link
Contributor

@Xiang-Gu I'm adding this to your queue.

@Xiang-Gu Xiang-Gu mentioned this issue Sep 1, 2022
Merged
@craig craig bot closed this as completed in e39111b Sep 7, 2022
@blathers-crl blathers-crl bot mentioned this issue Sep 7, 2022
Merged
@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) stability-period-v22.2 and removed T-sql-schema-deprecated Use T-sql-foundations instead stability-period Intended to be worked on during a stability period. Use with the Milestone field to specify version. labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xiang-Gu Xiang-Gu

Labels
A-disaster-recovery branch-master Failures and bugs on the master branch. C-investigation Further steps needed to qualify. C-label will change. GA-blocker stability-period-v22.2 T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
No open projects
Disaster Recovery Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sctest: Augmented BACKUP/RESTORE tests with table-level restore Xiang-Gu/cockroach
4 participants
@ajwerner @postamar @msbutler @Xiang-Gu