Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: BenchmarkMVCCGet failure with key not found #86131

Closed
erikgrinaker opened this issue Aug 15, 2022 · 2 comments · Fixed by #86166
Closed

storage: BenchmarkMVCCGet failure with key not found #86131

erikgrinaker opened this issue Aug 15, 2022 · 2 comments · Fixed by #86166
Assignees
@jbowens
Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. branch-master Failures and bugs on the master branch. branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-storage Storage Team

Comments

@erikgrinaker
Copy link
Contributor

erikgrinaker commented Aug 15, 2022 •
edited by exalate-issue-sync bot
Loading

BenchmarkMVCCGet_Pebble/batch=true/versions=10/valueSize=8/numRangeKeys=1 fails to find a key:

BenchmarkMVCCGet_Pebble/batch=true/versions=10/valueSize=8/numRangeKeys=1
    bench_test.go:983: failed get (key not found): 41431@5
--- FAIL: BenchmarkMVCCGet_Pebble/batch=true/versions=10/valueSize=8/numRangeKeys=1-24

Possibly related to #86088. Will have a closer look.

CC @jbowens.

Jira issue: CRDB-18592

Epic CRDB-2624
@erikgrinaker erikgrinaker added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-storage Storage Team labels Aug 15, 2022
@erikgrinaker erikgrinaker self-assigned this Aug 15, 2022
@blathers-crl blathers-crl bot added the A-storage Relating to our storage engine (Pebble) on-disk storage. label Aug 15, 2022
@erikgrinaker erikgrinaker added the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Aug 15, 2022
@blathers-crl
Copy link

blathers-crl bot commented Aug 15, 2022

Hi @erikgrinaker, please add branch-* labels to identify which branch(es) this release-blocker affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@erikgrinaker erikgrinaker added branch-master Failures and bugs on the master branch. branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 labels Aug 15, 2022
@erikgrinaker
Copy link
Contributor Author

erikgrinaker commented Aug 15, 2022 •
edited by jbowens
Loading

I tracked this down to #86111 as well -- if I re-enable range key masking for the MVCCGet iterator then the problem goes away. It only happens in the batch=true case, i.e. when we reuse the iterator. It is likely related to cockroachdb/pebble#1886 somehow.

@erikgrinaker erikgrinaker assigned jbowens and unassigned erikgrinaker Aug 15, 2022
@jbowens jbowens mentioned this issue Aug 15, 2022
Merged
@craig craig bot closed this as completed in 55e0f99 Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbowens jbowens

Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. branch-master Failures and bugs on the master branch. branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-storage Storage Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vendor: bump Pebble to 94bbf14378db jbowens/cockroach
2 participants
@erikgrinaker @jbowens