Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: adopt util/circuit #85811

Closed
tbg opened this issue Aug 9, 2022 · 2 comments
Closed

rpc: adopt util/circuit #85811

tbg opened this issue Aug 9, 2022 · 2 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity T-kv KV Team X-stale

Comments

@tbg
Copy link
Member

tbg commented Aug 9, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

The circuit breaker used in the rpc package recruits client traffic for probes, so it can cause stalls in user-facing traffic.

Describe the solution you'd like

Use util/rpc, which allows async probing and does not recruit user traffic.

Touches #69888
Touches #70111
Touches #53410

Jira issue: CRDB-18441
@tbg tbg added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team labels Aug 9, 2022
@tbg
Copy link
Member Author

tbg commented Aug 9, 2022

This would've possibly helped https://github.com/cockroachlabs/support/issues/1742

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 15, 2024
@github-project-automation github-project-automation bot moved this to Closed in KV Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity T-kv KV Team X-stale
Projects
No open projects
KV
Status: Closed
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tbg