Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlsmith: add a configuration that runs with the crdb_test build #83186

Closed
rytaft opened this issue Jun 22, 2022 · 0 comments · Fixed by #86625
Closed

sqlsmith: add a configuration that runs with the crdb_test build #83186

rytaft opened this issue Jun 22, 2022 · 0 comments · Fixed by #86625
Assignees
@yuzefovich
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-postmortem Originated from a Postmortem action item. T-sql-queries SQL Queries Team

Comments

@rytaft
Copy link
Collaborator

rytaft commented Jun 22, 2022 •
edited
Loading

The bug identified by #81968 was not caught by any of our tests, but it did trigger an assertion failure when the SQLite logic tests were run with the crdb_test build flag. The crdb_test build flag enables assertions and metamorphic testing that are not enabled in the normal binaries used by SQLSmith. We may be able to find more bugs if we have at least one configuration of SQLSmith testing that uses a crdb_test binary.

Epic: CRDB-14020
Jira issue: CRDB-16911
@rytaft rytaft added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-postmortem Originated from a Postmortem action item. labels Jun 22, 2022
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Jun 22, 2022
@yuzefovich yuzefovich self-assigned this Aug 23, 2022
@yuzefovich yuzefovich mentioned this issue Aug 23, 2022
Merged
@craig craig bot closed this as completed in eaa7eaf Aug 25, 2022
@mgartner mgartner moved this to Done in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuzefovich yuzefovich

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-postmortem Originated from a Postmortem action item. T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

roachtest: compile cockroach-short with --crdb_test and use in sqlsmith yuzefovich/cockroach
2 participants
@rytaft @yuzefovich