Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: core changefeeds don't check kv.rangefeed.enabled until after the initial scan #77735

Open
HonoreDB opened this issue Mar 13, 2022 · 2 comments
Labels
A-cdc Change Data Capture C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. E-quick-win Likely to be a quick win for someone experienced. T-cdc

Comments

@HonoreDB
Copy link
Contributor

HonoreDB commented Mar 13, 2022

Describe the problem

On crdb 21.2, a core changefeed on a table with data will emit all the existing rows before it errors with the expected rangefeeds require the kv.rangefeed.enabled setting. This is okay but non-ideal as it potentially separates the operator from the error.

Jira issue: CRDB-13743

@HonoreDB HonoreDB added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-cdc Change Data Capture T-cdc labels Mar 13, 2022
@blathers-crl
Copy link

blathers-crl bot commented Mar 13, 2022

cc @cockroachdb/cdc

@amruss amruss added the E-quick-win Likely to be a quick win for someone experienced. label Mar 23, 2022
@stevendanna
Copy link
Collaborator

Huh, I thought I had fixed this in e372d9e. I wonder if the issue here isn't the location of the check, but rather that the relevant cluster setting was marked TenantWritable: https://github.com/cockroachdb/cockroach/blob/master/pkg/kv/kvserver/replica_rangefeed.go#L46. when it really should be TenantReadOnly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cdc Change Data Capture C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. E-quick-win Likely to be a quick win for someone experienced. T-cdc
Projects
None yet
Development

No branches or pull requests

4 participants