seqexpr: ON UPDATE sequence expressions contain by-name references

[postamar]

I noticed this during recent declarative schema changer work.

CREATE SEQUENCE s;
CREATE TABLE foo (k INT PRIMARY KEY, v INT NOT NULL ON UPDATE (nextval('s')));
SELECT crdb_internal.pb_to_json('cockroach.sql.sqlbase.Descriptor', descriptor)->'table'->'columns' FROM system.descriptor WHERE id = 'foo'::REGCLASS::INT;

yields

  [{"id": 1, "name": "k", "type": {"family": "IntFamily", "oid": 20, "width": 64}}, {"defaultExpr": "nextval(104:::REGCLASS)", "id": 2, "name": "v", "onUpdateExpr": "nextval(\'s\':::STRING)", "type": {"family": "IntFamily", "oid": 20, "width": 64}, "usesSequenceIds": [104]}]

Instead we expect: "onUpdateExpr": "nextval(104:::REGCLASS)"

Jira issue: CRDB-13432

[postamar]

Relates somewhat to #76137

[postamar]

This involves also running a descriptor upgrade migration to ensure that all SeqIdentifiers in exprs are exclusively by-ID .