Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server, ui: retrieve formatted statement for stmt details page #75466

Closed
xinhaoz opened this issue Jan 24, 2022 · 1 comment
Closed

server, ui: retrieve formatted statement for stmt details page #75466

xinhaoz opened this issue Jan 24, 2022 · 1 comment
Assignees
@maryliag
Labels
A-sql-observability Related to observability of the SQL layer C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@xinhaoz
Copy link
Member

xinhaoz commented Jan 24, 2022 •
edited by cockroach-jira-scripts
Loading

Previously, statements returned in the combined statements endpoint were formated via a prettify_statement built-in. This was causing query performance issues with large result sets and so the formatting of statements returned in the combined stmts EP was removed in #75443.

We should create a new EP for the stmt details page to return the formatted statement, or format the stmt on the frontend.

Jira issue: CRDB-12684
@xinhaoz xinhaoz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-sql-observability Related to observability of the SQL layer T-sql-observability labels Jan 24, 2022
@exalate-issue-sync exalate-issue-sync bot mentioned this issue Jan 28, 2022
Closed
@jocrl jocrl closed this as completed Feb 2, 2022
@jocrl jocrl reopened this Feb 2, 2022
@maryliag maryliag self-assigned this Mar 2, 2022
@kevin-v-ngo kevin-v-ngo mentioned this issue Mar 4, 2022
Closed
@maryliag
Copy link
Contributor

done on #76592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryliag maryliag

Labels
A-sql-observability Related to observability of the SQL layer C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maryliag @xinhaoz @jocrl