Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvprober: write structured logs #74405

Closed
joshimhoff opened this issue Jan 4, 2022 · 1 comment
Closed

kvprober: write structured logs #74405

joshimhoff opened this issue Jan 4, 2022 · 1 comment
Labels
A-kv-observability C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity O-sre For issues SRE opened or otherwise cares about tracking. X-stale

Comments

@joshimhoff
Copy link
Collaborator

joshimhoff commented Jan 4, 2022

Is your feature request related to a problem? Please describe.
Today, the kvprober logs are text-based. These are hard to parse programatically. This makes it hard to analyze the logs programmatically, and also write alerts (we have time-series metrics for alerting but for single range issue a log-based alert may be the move).

Describe the solution you'd like
We could do structured logging via pkg/util/log/eventpb.

Describe alternatives you've considered
Only alternative I can think of is not doing anything.

Additional context
N/A

Jira issue: CRDB-12067

@joshimhoff joshimhoff added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-sre For issues SRE opened or otherwise cares about tracking. labels Jan 4, 2022
@github-actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-kv-observability C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity O-sre For issues SRE opened or otherwise cares about tracking. X-stale
Projects
None yet
Development

No branches or pull requests

1 participant