Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: extend the logic test coverage #7351

Closed
knz opened this issue Jun 21, 2016 · 1 comment
Closed

sql: extend the logic test coverage #7351

knz opened this issue Jun 21, 2016 · 1 comment
Assignees
Labels
C-investigation Further steps needed to qualify. C-label will change.

Comments

@knz
Copy link
Contributor

knz commented Jun 21, 2016

In the wake of #7202 @petermattis suggests to revisit the following comment in sql/logic_test.go pertaining to the bigtest:

// TODO(pmattis): We don't support aggregate functions.
// logicTestPath + "/test/random/expr/*.test",
// TODO(pmattis): We don't support tables without primary keys.
// logicTestPath + "/test/select*.test",
// TODO(pmattis): We don't support views.
// logicTestPath + "/test/index/view/*/*.test",
// TODO(pmattis): We don't support joins.
// [uses joins] logicTestPath + "/test/index/random/*/*.test",
// [uses joins] logicTestPath + "/test/random/aggregates/*.test",
// [uses joins] logicTestPath + "/test/random/groupby/*.test",
// [uses joins] logicTestPath + "/test/random/select/*.test",
@knz
Copy link
Contributor Author

knz commented Jun 30, 2016

This is a dup of #3292.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-investigation Further steps needed to qualify. C-label will change.
Projects
None yet
Development

No branches or pull requests

1 participant