util/log: tests fail on non-amd64 platforms

[amitsadaphule]

(edited 2021-11-01 by knz)

Describe the problem

The tests under util/log and util/log/logcrash assert the rendering of stack traces, which inclues the presence of a file asm_amd64.s inside the stack trace.

On non-amd64 platforms this file is not present in stack traces and the tests fail.

To Reproduce

run tests on non-amd64 platform, eg ARM or PPC.

Jira issue: CRDB-11049

[blathers-crl]

Hello, I am Blathers. I am here to help you get the issue triaged.

Hoot - a bug! Though bugs are the bane of my existence, rest assured the wretched thing will get the best of care here.

I have CC'd a few people who may be able to assist you:

• @cockroachdb/bulk-io (found keywords: export)

If we have not gotten back to your issue within a few business days, you can try the following:

• Join our community slack channel and ask on #cockroachdb.
• Try find someone from here if you know they worked closely on the area and CC them.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}

[blathers-crl]

cc @cockroachdb/bulk-io

[knz]

There are two separate (unrelated) issues here:

• a misdesign in the sql test
• platform compatibility in the log package

We need to split them into two different issues.

[knz]

@amitsadaphule why do you need these particular tests to pass?

Generally, CockroachDB's team does not support alternative build platforms, so we're likely not going to work actively to resolve this particular problem. However, on the other hand we have many users that report that cockroachDB works on their platform, even if not officially supported.

Does this block your work in any way?

[knz]

moved the SQL issue to #72284

[seth-priya]

Hi @knz thanks for your response, responding on behalf of @amitsadaphule as he is on vacation. To answer your query

@amitsadaphule why do you need these particular tests to pass?

Generally, CockroachDB's team does not support alternative build platforms, so we're likely not going to work actively to resolve this particular problem. However, on the other hand we have many users that report that cockroachDB works on their platform, even if not officially supported.

Does this block your work in any way?

I understand that alternative build platforms are not officially supported but the one way for us to ensure that cockroachdb won't run into any functional issues on ppc64le which is where we are currently trying to get it to work is to rely on its test suite and that is the reason why we are trying to get all the tests to work correctly including those mentioned in #72225 and #72226. It won't block us if it does not for example impact any functionality/feature but I am not sure we know enough at this point to be sure about that atleast on our side.

Any thoughts?

In the meantime, we are trying to debug and root cause the failures but any pointers from you / anyone else who is familiar with these areas of the code would be of great help, thank you!

[jtsiros]

cc: @cockroachdb/dev-inf for triage

[dt]

I fixed a similar case of these platform-specific stack traces in the SQL codebase with a quick trivial string replacement. Can we we just do the same thing in logcrash tests? d7efe41

[github-actions]

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!