Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: make default primary key names match Postgres naming convention #71087

Closed
rafiss opened this issue Oct 4, 2021 · 0 comments · Fixed by #70604
Closed

sql: make default primary key names match Postgres naming convention #71087

rafiss opened this issue Oct 4, 2021 · 0 comments · Fixed by #70604
Assignees
@otan
Labels
A-tools-prisma C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@rafiss
Copy link
Collaborator

rafiss commented Oct 4, 2021 •
edited
Loading

We have seen some tools rely on this naming convention when running their test suites. The name should be (table_name)_pkey.

Making this change would make it easier for us to test compatibility with these tools.

Epic CRDB-1379
@rafiss rafiss added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-tools-prisma labels Oct 4, 2021
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Oct 4, 2021
@rafiss rafiss mentioned this issue Oct 4, 2021
Merged
@craig craig bot closed this as completed in 96bb0bc Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@otan otan

Labels
A-tools-prisma C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: name PRIMARY KEY constraints (table_name)_pkey by default otan-cockroach/cockroach
2 participants
@rafiss @otan