Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sql.telemetry.query_sampling.enabled cluster setting to be on by default #70775

Closed
thtruo opened this issue Sep 27, 2021 · 1 comment · Fixed by #70890
Closed

Update sql.telemetry.query_sampling.enabled cluster setting to be on by default #70775

thtruo opened this issue Sep 27, 2021 · 1 comment · Fixed by #70890
Assignees
@logston
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker

Comments

@thtruo
Copy link
Contributor

thtruo commented Sep 27, 2021

Request

From @logston

There's a new feature flag sql.telemetry.query_sampling.enabled that blocks telemetry logging and enabling it on each tenant cluster after startup is a big ask (probably will not get done before launch).

The best way to go about unblocking the Serverless launch is to change that cluster setting's default. At least for tenant pods. In fact, only for tenant pods if possible. If differentiating between KV pods and dedicated pods is too difficult, then enabling by default for all pods is the next best option.

(based off this acceptance testing comment in Jira)
@thtruo thtruo added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-observability labels Sep 27, 2021
@thtruo
Copy link
Contributor Author

thtruo commented Sep 27, 2021

cc @kevin-v-ngo and @maryliag for awareness and triage

@maryliag maryliag assigned logston and unassigned xinhaoz Sep 29, 2021
@logston logston mentioned this issue Sep 29, 2021
Merged
@craig craig bot closed this as completed in 99a0138 Oct 5, 2021
@blathers-crl blathers-crl bot mentioned this issue Oct 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@logston logston

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: Enable telemetry query_sampling by default
4 participants
@maryliag @thtruo @logston @xinhaoz