Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: make the hardware metric observer container-aware #54204

Closed
knz opened this issue Sep 10, 2020 · 2 comments
Closed

server: make the hardware metric observer container-aware #54204

knz opened this issue Sep 10, 2020 · 2 comments
Labels
A-kv-server Relating to the KV-level RPC server C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@knz
Copy link
Contributor

knz commented Sep 10, 2020

Currently we use gosigar which asks the OS, but this does not take into account limits set by the orchestrator / container server.

We want to have container limits instead. @ajwerner has some technical references about what to use.
@blathers-crl
Copy link

blathers-crl bot commented Sep 10, 2020

Hi @knz, please add a C-ategory label to your issue. Check out the label system docs.

While you're here, please consider adding an A- label to help keep our repository tidy.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@knz knz added A-kv-server Relating to the KV-level RPC server C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) labels Sep 10, 2020
@knz knz mentioned this issue Oct 1, 2020
Closed
@knz
Copy link
Contributor Author

knz commented Jan 18, 2021

Addressed by @itsbilal

@knz knz closed this as completed Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-kv-server Relating to the KV-level RPC server C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@knz