Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv: split read and write request rate limiters #53483

Closed
nvanbenschoten opened this issue Aug 26, 2020 · 0 comments · Fixed by #53510
Closed

kv: split read and write request rate limiters #53483

nvanbenschoten opened this issue Aug 26, 2020 · 0 comments · Fixed by #53510
Assignees
@nvanbenschoten
Labels
A-multitenancy Related to multi-tenancy C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@nvanbenschoten
Copy link
Member

Read and write requests have very different costs. They shouldn't pull from the same token bucket.
@nvanbenschoten nvanbenschoten added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-multitenancy Related to multi-tenancy labels Aug 26, 2020
@nvanbenschoten nvanbenschoten self-assigned this Aug 26, 2020
@nvanbenschoten nvanbenschoten mentioned this issue Aug 27, 2020
Merged
@craig craig bot closed this as completed in e43acc9 Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvanbenschoten nvanbenschoten

Labels
A-multitenancy Related to multi-tenancy C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kv: split rate limits and metrics for read and write requests nvanbenschoten/cockroach
1 participant
@nvanbenschoten