Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: add hardcoded map information to Cockroach Demo for standard multi-regions #39941

Closed
awoods187 opened this issue Aug 23, 2019 · 3 comments
Closed
Labels
A-demo C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@awoods187
Copy link
Contributor

awoods187 commented Aug 23, 2019

For use both in #39938 and in other kinds of testing. We can set out a list of "known" locations with hardcoded lats/longs so that the webui map works.

In addition to the ones in #39938, I think we should add asia information as well.

If i user sets something like:
./cockroach demo movr --nodes 3 --demo-locality=region=us-east1,region=us-central1,region=us-west1

Then we would hard code recognize us-east1 as a specific lat/long and insert it into the MovR database to enable the webui

@awoods187 awoods187 added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-cli labels Aug 23, 2019
@jordanlewis
Copy link
Member

I actually just filed this as #39937 - sorry 😱

@awoods187
Copy link
Contributor Author

cool will close this

@jordanlewis
Copy link
Member

In other words, I don't think there's any reason to make this specific to the demo - I think hardcoded system.locations for all of the known region codes is a great idea for testing and prod. Right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-demo C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Development

No branches or pull requests

2 participants