Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/log: enable logging using the system TZ instead of UTC #39097

Closed
mattcrdb opened this issue Jul 25, 2019 · 3 comments · Fixed by #104265
Closed

util/log: enable logging using the system TZ instead of UTC #39097

mattcrdb opened this issue Jul 25, 2019 · 3 comments · Fixed by #104265
Assignees
@knz
Labels
A-logging In and around the logging infrastructure. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs

Comments

@mattcrdb
Copy link

mattcrdb commented Jul 25, 2019 •
edited by knz
Loading

Cockroach logs currently log in UTC time format.

An option to change this setting to log in system time would be very beneficial to users that have other logs using the same format.

The solution would allow a more simple debugging experience for folks with other application logs in system time.

Jira issue: CRDB-5594
Epic: CRDB-24406
@mattcrdb mattcrdb added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Jul 25, 2019
@tim-o
Copy link
Contributor

tim-o commented Jul 25, 2019

We've received two separate issues with similar requests: one asking for the ability to log in system time, another asking for the ability to display the Web UI in another timezone. One simple solution might be to have a cluster setting for the timezone that'd change both the logs and the UI TZ's.

This will have implications for our debugging, so we'd need to have a warning at the top of each log indicating what TZ the logs and UI are using.

@RoachietheSupportRoach
Copy link
Collaborator

Zendesk ticket #3511 has been linked to this issue.

@RoachietheSupportRoach
Copy link
Collaborator

Zendesk ticket #3523 has been linked to this issue.

@tim-o tim-o added the O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs label Jul 25, 2019
@ricardocrdb ricardocrdb mentioned this issue Nov 21, 2019
Closed
@knz knz added the A-logging In and around the logging infrastructure. label Mar 4, 2020
@knz knz changed the title Cockroach logs in system time (currently UTC only) util/log: enable logging using the system TZ instead of UTC Mar 4, 2020
@jlinder jlinder added the T-server-and-security DB Server & Security label Jun 16, 2021
@thtruo thtruo added T-observability-inf and removed T-server-and-security DB Server & Security labels Feb 18, 2022
@knz knz self-assigned this Jun 6, 2023
@knz knz mentioned this issue Jun 6, 2023
Merged
@craig craig bot closed this as completed in d43dd82 Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knz knz

Labels
A-logging In and around the logging infrastructure. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

util/log: new config field format-options, custom timezones in log output knz/cockroach
7 participants
@jlinder @knz @thtruo @piyush-singh @tim-o @mattcrdb @RoachietheSupportRoach