Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: should signal readiness (--background) later #35070

Closed
tbg opened this issue Feb 19, 2019 · 1 comment
Closed

server: should signal readiness (--background) later #35070

tbg opened this issue Feb 19, 2019 · 1 comment
Labels
A-kv-server Relating to the KV-level RPC server A-server-architecture Relates to the internal APIs and src org for server code A-server-start-drain Pertains to server startup and shutdown sequences C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity T-server-and-security DB Server & Security X-stale

Comments

@tbg
Copy link
Member

tbg commented Feb 19, 2019

See #34897 (comment)

TL;DR: --background currently signals readiness here:

cockroach/pkg/server/server.go

Lines 1375 to 1380 in 475958d

if len(bootstrappedEngines) > 0 {
// The cluster was already initialized.
doBootstrap = false
if s.cfg.ReadyFn != nil {
s.cfg.ReadyFn(false /*waitForInit*/)
}

But that's too early - it may still take a while (tens of seconds) until the node is actually responsive.

Jira issue: CRDB-4609

@tbg tbg added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Feb 19, 2019
@tbg tbg added this to the 2.2 milestone Feb 19, 2019
@awoods187 awoods187 removed this from the 19.1 milestone Mar 22, 2019
@lunevalex lunevalex added the A-kv-server Relating to the KV-level RPC server label Jul 29, 2020
@jlinder jlinder added the T-server-and-security DB Server & Security label Jun 16, 2021
@knz knz added A-server-start-drain Pertains to server startup and shutdown sequences A-server-architecture Relates to the internal APIs and src org for server code labels Jul 29, 2021
@github-actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-kv-server Relating to the KV-level RPC server A-server-architecture Relates to the internal APIs and src org for server code A-server-start-drain Pertains to server startup and shutdown sequences C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity T-server-and-security DB Server & Security X-stale
Projects
No open projects
Status: Done 21.2
Development

No branches or pull requests

5 participants