Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: foreign key validation #34597

Closed
thoszhang opened this issue Feb 5, 2019 · 1 comment
Closed

roachtest: foreign key validation #34597

thoszhang opened this issue Feb 5, 2019 · 1 comment
Assignees
@thoszhang
Labels
A-schema-changes C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.

Comments

@thoszhang
Copy link
Contributor

We need a roachtest for the performance and correctness of foreign key validation.

It would be straightforward to add a validation step to an existing roachtest (possibly the schemachange one), but we might still have problems with long-running schema change transactions getting stuck, even with the recent performance improvement in #34365. So we may have to start off with a smaller-scale roachtest, and scale up only after making the necessary changes to do the validation query in a separate transaction.
@thoszhang thoszhang self-assigned this Feb 5, 2019
@awoods187 awoods187 added the C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. label Mar 6, 2019
@thoszhang
Copy link
Contributor Author

Closing since we haven't seen any problems with this in a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thoszhang thoszhang

Labels
A-schema-changes C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thoszhang @awoods187