Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: refactor the ORM tests to anchor them to cockroachdb development #28069

Closed
benesch opened this issue Jul 30, 2018 · 7 comments
Closed

sql: refactor the ORM tests to anchor them to cockroachdb development #28069

benesch opened this issue Jul 30, 2018 · 7 comments
Labels
A-build-system A-testing Testing tools and infrastructure C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. no-issue-activity T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Milestone

Comments

@benesch
Copy link
Contributor

benesch commented Jul 30, 2018

The examples-orms job that gets run in CI is extremely flaky. There are several problems:

  1. Its dependencies aren't vendored, so it's hitting public package repositories on every build.
  2. It's not pinned to a particular SHA. The latest master of examples-orms is always used. This can make builds of cockroach that were fine one minute start failing the next.
  3. Its tests aren't correct. There is at least one missing transaction retry loop, probably more.

We should probably just merge examples-orms into this repository.

Jira issue: CRDB-4929

@awoods187
Copy link
Contributor

CC @BramGruneir and @knz I think we need to do some work on this in the current milestone. I spoke with @benesch and he said that we could make large progress with a day's worth of work or do everything needed with a week. I say let's not let perfect be the enemy of good and do the day's worth of work here to get ORM testing in place. The last thing we want is to break what ORM functioning we do have in place

@awoods187 awoods187 added this to the 2.1 milestone Sep 18, 2018
@knz knz added A-testing Testing tools and infrastructure C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. labels Sep 20, 2018
@knz knz modified the milestones: 2.1, 2.2 Oct 15, 2018
@knz knz changed the title build: examples-orms is flaky sql: refactor the ORM tests to anchor them to cockroachdb development Oct 23, 2018
@kenliu kenliu modified the milestones: 19.1, 19.2 Jul 12, 2019
@jlinder
Copy link
Collaborator

jlinder commented Sep 4, 2020

@rafiss I've seen you doing some work with examples orms. Is this something that's still interesting? Perhaps it's better on the AppDev board?

@rafiss
Copy link
Collaborator

rafiss commented Sep 4, 2020

Yeah this should be in our board. It looks like points 1 and 2 in the initial description of this issue already have been created as separate issues, independently:

@rafiss rafiss added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label May 12, 2021
@github-actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@jlinder
Copy link
Collaborator

jlinder commented Sep 21, 2023

@rafiss do you know #3 in the list is still relevant?

@rafiss
Copy link
Collaborator

rafiss commented Sep 21, 2023

I'm not aware of 3 being an issue any more.

@jlinder
Copy link
Collaborator

jlinder commented Sep 21, 2023

Great. Then we'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build-system A-testing Testing tools and infrastructure C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. no-issue-activity T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Development

No branches or pull requests

6 participants