Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv: reduce latch contention for GCRequest #24237

Closed
tbg opened this issue Mar 26, 2018 · 1 comment
Closed

kv: reduce latch contention for GCRequest #24237

tbg opened this issue Mar 26, 2018 · 1 comment
Assignees
@tbg @nvanbenschoten
Labels
A-kv-transactions Relating to MVCC and the transactional model. C-performance Perf of queries or internals. Solution not expected to change functional behavior. T-kv KV Team

Comments

@tbg
Copy link
Member

tbg commented Mar 26, 2018 •
edited by cockroach-jira-scripts
Loading

GCRequest is special in that it only affects data that is not observable by regular reads and writes. As such, they shouldn't need command queue serialization with anything else.

@nvanbenschoten pointed this out in #24209.

The effects of these optimizations should be observable in tests like #24236.

Jira issue: CRDB-5778
@tbg tbg added this to the 2.1 milestone Mar 26, 2018
@tbg tbg self-assigned this Mar 26, 2018
@tbg tbg mentioned this issue Mar 26, 2018
Merged
@tbg tbg added the A-storage Relating to our storage engine (Pebble) on-disk storage. label May 15, 2018
@tbg tbg modified the milestones: 2.1, 2.2 Jul 19, 2018
@tbg tbg added the C-performance Perf of queries or internals. Solution not expected to change functional behavior. label Jul 22, 2018
@tbg tbg added A-coreperf and removed A-disaster-recovery A-kv-transactions Relating to MVCC and the transactional model. A-kv-distribution Relating to rebalancing and leasing. A-kv-client Relating to the KV client and the KV interface. A-storage Relating to our storage engine (Pebble) on-disk storage. A-kv-replication Relating to Raft, consensus, and coordination. labels Jul 31, 2018
@petermattis petermattis removed this from the 2.2 milestone Oct 5, 2018
@tbg tbg removed the A-coreperf label Oct 11, 2018
@nvanbenschoten nvanbenschoten changed the title storage: reduce command queue contention for GCRequest storage: reduce latch contention for GCRequest Jul 7, 2020
@nvanbenschoten nvanbenschoten changed the title storage: reduce latch contention for GCRequest kv: reduce latch contention for GCRequest Jul 7, 2020
@nvanbenschoten nvanbenschoten added the A-kv-transactions Relating to MVCC and the transactional model. label Jul 7, 2020
@nvanbenschoten nvanbenschoten self-assigned this Jul 8, 2020
@jlinder jlinder added the T-kv KV Team label Jun 16, 2021
@nvanbenschoten
Copy link
Member

Duplicate of #55293.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbg tbg

@nvanbenschoten nvanbenschoten

Labels
A-kv-transactions Relating to MVCC and the transactional model. C-performance Perf of queries or internals. Solution not expected to change functional behavior. T-kv KV Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jlinder @tbg @nvanbenschoten @petermattis