Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: transaction / session cancellation #18736

Closed
5 tasks
dianasaur323 opened this issue Sep 25, 2017 · 9 comments
Closed
5 tasks

sql: transaction / session cancellation #18736

dianasaur323 opened this issue Sep 25, 2017 · 9 comments
Assignees
@andreimatei
Labels
A-sql-executor SQL txn logic C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) meta-issue Contains a list of several other issues.
Milestone
2.1

Comments

@dianasaur323
Copy link
Contributor

dianasaur323 commented Sep 25, 2017 •
edited by jordanlewis
Loading

Rationale
This is follow-up work related to query cancellation. We currently do not allow cancellation of transactions or sessions. These are both important features that other SQL databases offer, so we should offer these features to improve manageability and parity.

PM Acceptance Testing

  • Run a transaction
  • Observe what things look like in Show Queries and Show Sessions
  • Cancel transaction
  • Run multiple queries from a single session
  • Cancel session
@dianasaur323 dianasaur323 added this to the 1.2 milestone Sep 25, 2017
@dianasaur323 dianasaur323 self-assigned this Sep 25, 2017
@awoods187 awoods187 assigned awoods187 and unassigned dianasaur323 Nov 1, 2017
@vivekmenezes vivekmenezes changed the title sql: transaction / session cancellation (acceptance testing) sql: transaction / session cancellation Jan 2, 2018
@vivekmenezes
Copy link
Contributor

#17252

@dianasaur323
Copy link
Contributor Author

thanks @vivekmenezes!

@vivekmenezes
Copy link
Contributor

sorry @dianasaur323 . not yet!

@dianasaur323
Copy link
Contributor Author

=.='

@jordanlewis
Copy link
Member

We still haven't implemented session or transaction cancellation, and it's not going to happen for 2.0.

@jordanlewis jordanlewis modified the milestones: 2.0, 2.1 Mar 5, 2018
@dianasaur323
Copy link
Contributor Author

yep, time is allocated in 2.1. Thanks for moving the milestone.

@awoods187 awoods187 removed their assignment Mar 5, 2018
@knz knz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) meta-issue Contains a list of several other issues. labels Apr 27, 2018
@knz knz added the A-sql-executor SQL txn logic label May 9, 2018
@nstewart
Copy link
Contributor

nstewart commented May 16, 2018 •
edited
Loading

Can we get an update on what's left to do here now that #23861 merged? I see an RFC is still open: #17252 cc @vivekmenezes

@vivekmenezes
Copy link
Contributor

assigning @andreimatei because he would like to make some improvement here. I'm not sure whether this works but it should definitely be QA-ed once andrei is happy with it.

@andreimatei
Copy link
Contributor

I would actually close this since we now have session cancelation and also set statement_timeout. This issue also talks about "txn cancelation", but that's not defined here so I think this issue is not serving any purpose.

@vivekmenezes vivekmenezes mentioned this issue May 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreimatei andreimatei

Labels
A-sql-executor SQL txn logic C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) meta-issue Contains a list of several other issues.
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
8 participants
@jordanlewis @andreimatei @pbardea @knz @nstewart @dianasaur323 @vivekmenezes @awoods187