Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv/kvclient/kvcoord: TestMuxRangeFeedDoesNotStallOnError failed #136316

Open
cockroach-teamcity opened this issue Nov 27, 2024 · 6 comments · May be fixed by #136415
Open

kv/kvclient/kvcoord: TestMuxRangeFeedDoesNotStallOnError failed #136316

cockroach-teamcity opened this issue Nov 27, 2024 · 6 comments · May be fixed by #136415
Assignees
@arulajmani
Labels
A-testing Testing tools and infrastructure branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-kv KV Team

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Nov 27, 2024 •
edited by cockroach-jira-scripts
Loading

kv/kvclient/kvcoord.TestMuxRangeFeedDoesNotStallOnError failed with artifacts on master @ fa7b97990f45bdf3d7f7896b66379489934091c8:

=== RUN   TestMuxRangeFeedDoesNotStallOnError
    test_log_scope.go:165: test logs captured to: /artifacts/tmp/_tmp/a38679e165d5c98145544b9bfab9e765/logTestMuxRangeFeedDoesNotStallOnError1337178714
    test_log_scope.go:76: use -show-logs to present logs inline
    test_server_shim.go:139: cluster virtualization disabled in global scope due to issue: #76378 (expected label: C-bug)
    dist_sender_rangefeed_test.go:389: condition failed to evaluate within 45s: from dist_sender_rangefeed_test.go:395: at least one non-local range required for test
    panic.go:626: -- test log scope end --
--- FAIL: TestMuxRangeFeedDoesNotStallOnError (49.25s)
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/kv

This test on roachdash | Improve this report!

Jira issue: CRDB-44970
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-kv KV Team labels Nov 27, 2024
@github-actions GitHub Actions
Copy link

kv/kvclient/kvcoord.TestMuxRangeFeedDoesNotStallOnError failed on master @ c9257531b739e41eee3d5d57fad6324eaac5d639:

=== RUN   TestMuxRangeFeedDoesNotStallOnError
    test_log_scope.go:165: test logs captured to: outputs.zip/logTestMuxRangeFeedDoesNotStallOnError1198822237
    test_log_scope.go:76: use -show-logs to present logs inline
    test_server_shim.go:139: cluster virtualization disabled in global scope due to issue: #76378 (expected label: C-bug)
    dist_sender_rangefeed_test.go:389: condition failed to evaluate within 45s: from dist_sender_rangefeed_test.go:395: at least one non-local range required for test
    panic.go:626: -- test log scope end --
test logs left over in: outputs.zip/logTestMuxRangeFeedDoesNotStallOnError1198822237
--- FAIL: TestMuxRangeFeedDoesNotStallOnError (48.38s)

Parameters:

  • attempt=1
  • run=1
  • shard=12
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

kv/kvclient/kvcoord.TestMuxRangeFeedDoesNotStallOnError failed with artifacts on master @ 0f2422bac446d1d297cec730ec7817aef46bd2be:

=== RUN   TestMuxRangeFeedDoesNotStallOnError
I241128 18:43:29.346669 1 (gostd) rand.go:246  [-] 1  random seed: -3010804462599978228
    test_log_scope.go:165: test logs captured to: /artifacts/tmp/_tmp/a38679e165d5c98145544b9bfab9e765/logTestMuxRangeFeedDoesNotStallOnError3232800795
    test_log_scope.go:76: use -show-logs to present logs inline
    test_server_shim.go:139: cluster virtualization disabled in global scope due to issue: #76378 (expected label: C-bug)
    dist_sender_rangefeed_test.go:389: condition failed to evaluate within 45s: from dist_sender_rangefeed_test.go:395: at least one non-local range required for test
    panic.go:626: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/a38679e165d5c98145544b9bfab9e765/logTestMuxRangeFeedDoesNotStallOnError3232800795
--- FAIL: TestMuxRangeFeedDoesNotStallOnError (48.14s)
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

kv/kvclient/kvcoord.TestMuxRangeFeedDoesNotStallOnError failed with artifacts on master @ c9257531b739e41eee3d5d57fad6324eaac5d639:

=== RUN   TestMuxRangeFeedDoesNotStallOnError
    test_log_scope.go:165: test logs captured to: /artifacts/tmp/_tmp/a38679e165d5c98145544b9bfab9e765/logTestMuxRangeFeedDoesNotStallOnError3181259480
    test_log_scope.go:76: use -show-logs to present logs inline
    test_server_shim.go:139: cluster virtualization disabled in global scope due to issue: #76378 (expected label: C-bug)
    dist_sender_rangefeed_test.go:389: condition failed to evaluate within 45s: from dist_sender_rangefeed_test.go:395: at least one non-local range required for test
    panic.go:626: -- test log scope end --
--- FAIL: TestMuxRangeFeedDoesNotStallOnError (48.69s)
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@arulajmani
Copy link
Collaborator

This test was merged a couple of days ago and has been flaky since (#134776).

@arulajmani arulajmani self-assigned this Nov 29, 2024
@arulajmani arulajmani removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Nov 29, 2024
@arulajmani
Copy link
Collaborator

Not a release blocker because the test fails during setup. I'll send out a PR to deflake.

arulajmani added a commit to arulajmani/cockroach that referenced this issue Nov 29, 2024
@arulajmani
kvclient: deflake TestMuxRangeFeedDoesNotStallOnError
7fa456e 
During setup, this test wants to ensure that there's atleast one
non-local range to node 1. Previously, we'd only scatter once,
which meant if we got unlucky on that scatter, the setup condition
could never be satisfied. This patch moves the scatter into the
succeeds soon bit where we're checking the non-local range condition.

Closes cockroachdb#136316

Release note: None
@arulajmani arulajmani linked a pull request Nov 29, 2024 that will close this issue
Open
@arulajmani arulajmani added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-testing Testing tools and infrastructure labels Nov 29, 2024
@cockroach-teamcity
Copy link
Member Author

kv/kvclient/kvcoord.TestMuxRangeFeedDoesNotStallOnError failed on master @ bcc993d796d03664604bf695e38fd5644d0bc952:

=== RUN   TestMuxRangeFeedDoesNotStallOnError
    test_log_scope.go:165: test logs captured to: outputs.zip/logTestMuxRangeFeedDoesNotStallOnError2853565186
    test_log_scope.go:76: use -show-logs to present logs inline
    test_server_shim.go:139: cluster virtualization disabled in global scope due to issue: #76378 (expected label: C-bug)
    dist_sender_rangefeed_test.go:389: condition failed to evaluate within 45s: from dist_sender_rangefeed_test.go:395: at least one non-local range required for test
    panic.go:626: -- test log scope end --
test logs left over in: outputs.zip/logTestMuxRangeFeedDoesNotStallOnError2853565186
--- FAIL: TestMuxRangeFeedDoesNotStallOnError (50.19s)

Parameters:

  • attempt=1
  • run=11
  • shard=12
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arulajmani arulajmani

Labels
A-testing Testing tools and infrastructure branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-kv KV Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kvclient: deflake TestMuxRangeFeedDoesNotStallOnError arulajmani/cockroach
2 participants
@arulajmani @cockroach-teamcity