Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sentry: logical_props_builder.go:1736: comparison overload not found (×, ×, ×) (1) assertion failure Wraps: (2) attached stack trace -- stack trace: | github.com/cockroachdb/cockroach/pkg/sql/o... #133084

Closed
cockroach-sentry opened this issue Oct 21, 2024 · 1 comment
Closed

Sentry: logical_props_builder.go:1736: comparison overload not found (×, ×, ×) (1) assertion failure Wraps: (2) attached stack trace -- stack trace: | github.com/cockroachdb/cockroach/pkg/sql/o... #133084

cockroach-sentry opened this issue Oct 21, 2024 · 1 comment
Labels
branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-sentry Originated from an in-the-wild panic report. T-sql-queries SQL Queries Team X-blathers-triaged blathers was able to find an owner

Comments

@cockroach-sentry
Copy link
Collaborator

cockroach-sentry commented Oct 21, 2024 •
edited by cockroach-jira-scripts
Loading

This issue was auto filed by Sentry. It represents a crash or reported error on a live cluster with telemetry enabled.

Sentry Link: https://cockroach-labs.sentry.io/issues/6009944010/?referrer=webhooks_plugin

Panic Message:

logical_props_builder.go:1736: comparison overload not found (×, ×, ×)
(1) assertion failure
Wraps: (2) attached stack trace
  -- stack trace:
  | github.com/cockroachdb/cockroach/pkg/sql/opt/memo.BuildSharedProps
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/memo/logical_props_builder.go:1736
  | github.com/cockroachdb/cockroach/pkg/sql/opt/memo.BuildSharedProps
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/memo/logical_props_builder.go:1790
  | github.com/cockroachdb/cockroach/pkg/sql/opt/memo.(*logicalPropsBuilder).buildFiltersItemProps
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/memo/logical_props_builder.go:1583
  | github.com/cockroachdb/cockroach/pkg/sql/opt/memo.(*FiltersItem).PopulateProps
  | 	github.com/cockroachdb/cockroach/bazel-out/k8-opt/bin/pkg/sql/opt/memo/expr.og.go:9791
  | github.com/cockroachdb/cockroach/pkg/sql/opt/norm.(*Factory).copyAndReplaceDefaultFiltersExpr
  | 	github.com/cockroachdb/cockroach/bazel-out/k8-opt/bin/pkg/sql/opt/norm/factory.og.go:25961
  | github.com/cockroachdb/cockroach/pkg/sql/opt/norm.(*Factory).CopyAndReplaceDefault
  | 	github.com/cockroachdb/cockroach/bazel-out/k8-opt/bin/pkg/sql/opt/norm/factory.og.go:24644
  | github.com/cockroachdb/cockroach/pkg/sql/opt/norm.(*Factory).AssignPlaceholders.func2
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/norm/factory.go:387
  | github.com/cockroachdb/cockroach/pkg/sql/opt/norm.(*Factory).invokeReplace
  | 	github.com/cockroachdb/cockroach/bazel-out/k8-opt/bin/pkg/sql/opt/norm/factory.og.go:26014
  | github.com/cockroachdb/cockroach/pkg/sql/opt/norm.(*Factory).CopyAndReplace
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/norm/factory.go:324
  | github.com/cockroachdb/cockroach/pkg/sql/opt/norm.(*Factory).AssignPlaceholders
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/norm/factory.go:389
  | github.com/cockroachdb/cockroach/pkg/sql.(*optPlanningCtx).reuseMemo
  | 	github.com/cockroachdb/cockroach/pkg/sql/plan_opt.go:516
  | github.com/cockroachdb/cockroach/pkg/sql.(*optPlanningCtx).buildExecMemo
  | 	github.com/cockroachdb/cockroach/pkg/sql/plan_opt.go:549
  | github.com/cockroachdb/cockroach/pkg/sql.(*planner).makeOptimizerPlan
  | 	github.com/cockroachdb/cockroach/pkg/sql/plan_opt.go:245
  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).makeExecPlan
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:2291
  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).dispatchToExecutionEngine
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:1763
  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execStmtInOpenState
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:1128
  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execStmt.func1
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:145
  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execWithProfiling
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:3407
  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execStmt
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:144
  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execPortal
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:250
  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execCmd.func2
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2368
  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execCmd
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2370
  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).run
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2185
  | github.com/cockroachdb/cockroach/pkg/sql.(*Server).ServeConn
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:969
  | github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).processCommands
  | 	github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:247
  | github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).serveImpl.func3
  | 	github.com/cockroachdb/cockroach/pkg/sql/pgwire/server.go:1002
  | runtime.goexit
  | 	src/runtime/asm_amd64.s:1650
Wraps: (3) comparison overload not found (×, ×, ×)
Error types: (1) *assert.withAssertionFailure (2) *withstack.withStack (3) *errutil.leafError
-- report composition:
*errutil.leafError: comparison overload not found (×, ×, ×)
logical_props_builder.go:1736: *withstack.withStack (top exception)
*assert.withAssertionFailure
Stacktrace (expand for inline code snippets):

src/runtime/asm_amd64.s#L1649-L1651

cockroach/pkg/sql/pgwire/server.go

Lines 1001 to 1003 in 7b9d20d

defer procWg.Done()
c.processCommands(
ctx,

cockroach/pkg/sql/pgwire/conn.go

Lines 246 to 248 in 7b9d20d

reservedOwned = false // We're about to pass ownership away.
retErr = sqlServer.ServeConn(
ctx,

cockroach/pkg/sql/conn_executor.go

Lines 968 to 970 in 7b9d20d

}(ctx, h)
return h.ex.run(ctx, s.pool, reserved, cancel)
}

cockroach/pkg/sql/conn_executor.go

Lines 2184 to 2186 in 7b9d20d

var err error
if err = ex.execCmd(); err != nil {
// Both of these errors are normal ways for the connExecutor to exit.

cockroach/pkg/sql/conn_executor.go

Lines 2369 to 2371 in 7b9d20d

return err
}()
// Note: we write to ex.statsCollector.phaseTimes, instead of ex.phaseTimes,

cockroach/pkg/sql/conn_executor.go

Lines 2367 to 2369 in 7b9d20d

canAutoCommit := ex.implicitTxn() && tcmd.FollowedBySync
ev, payload, err = ex.execPortal(ctx, portal, portalName, stmtRes, pinfo, canAutoCommit)
return err

cockroach/pkg/sql/conn_executor_exec.go

Lines 249 to 251 in 7b9d20d

}
ev, payload, retErr = ex.execStmt(ctx, portal.Stmt.Statement, &portal, pinfo, stmtRes, canAutoCommit)
// For a non-pausable portal, it is considered exhausted regardless of the

cockroach/pkg/sql/conn_executor_exec.go

Lines 143 to 145 in 7b9d20d

}
err = ex.execWithProfiling(ctx, ast, preparedStmt, func(ctx context.Context) error {
ev, payload, err = ex.execStmtInOpenState(ctx, parserStmt, portal, pinfo, res, canAutoCommit)

cockroach/pkg/sql/conn_executor_exec.go

Lines 3406 to 3408 in 7b9d20d

} else {
err = op(ctx)
}

cockroach/pkg/sql/conn_executor_exec.go

Lines 144 to 146 in 7b9d20d

err = ex.execWithProfiling(ctx, ast, preparedStmt, func(ctx context.Context) error {
ev, payload, err = ex.execStmtInOpenState(ctx, parserStmt, portal, pinfo, res, canAutoCommit)
return err

cockroach/pkg/sql/conn_executor_exec.go

Lines 1127 to 1129 in 7b9d20d

} else {
if err := ex.dispatchToExecutionEngine(stmtCtx, p, res); err != nil {
stmtThresholdSpan.Finish()

cockroach/pkg/sql/conn_executor_exec.go

Lines 1762 to 1764 in 7b9d20d

// between here and there needs to happen even if there's an error.
err = ex.makeExecPlan(ctx, planner)
defer planner.curPlan.close(ctx)

cockroach/pkg/sql/conn_executor_exec.go

Lines 2290 to 2292 in 7b9d20d

if err := planner.makeOptimizerPlan(ctx); err != nil {
log.VEventf(ctx, 1, "optimizer plan failed: %v", err)

cockroach/pkg/sql/plan_opt.go

Lines 244 to 246 in 7b9d20d

execMemo, err := opc.buildExecMemo(ctx)
if err != nil {

cockroach/pkg/sql/plan_opt.go

Lines 548 to 550 in 7b9d20d

opc.log(ctx, "reusing cached memo")
memo, err := opc.reuseMemo(ctx, prepared.Memo)
return memo, err

cockroach/pkg/sql/plan_opt.go

Lines 515 to 517 in 7b9d20d

f.FoldingControl().AllowStableFolds()
if err := f.AssignPlaceholders(cachedMemo); err != nil {
return nil, err

cockroach/pkg/sql/opt/norm/factory.go

Lines 388 to 390 in 7b9d20d

}
f.CopyAndReplace(from.RootExpr().(memo.RelExpr), from.RootProps(), replaceFn)

cockroach/pkg/sql/opt/norm/factory.go

Lines 323 to 325 in 7b9d20d

// factory's memo.
to := f.invokeReplace(from, replace).(memo.RelExpr)
f.Memo().SetRoot(to, fromProps)

https://github.com/cockroachdb/cockroach/blob/7b9d20d87208db1ac6c24b68b73c742eb9b1168d/bazel-out/k8-opt/bin/pkg/sql/opt/norm/factory.og.go#L26013-L26015

cockroach/pkg/sql/opt/norm/factory.go

Lines 386 to 388 in 7b9d20d

}
return f.CopyAndReplaceDefault(e, replaceFn)
}

https://github.com/cockroachdb/cockroach/blob/7b9d20d87208db1ac6c24b68b73c742eb9b1168d/bazel-out/k8-opt/bin/pkg/sql/opt/norm/factory.og.go#L24643-L24645
https://github.com/cockroachdb/cockroach/blob/7b9d20d87208db1ac6c24b68b73c742eb9b1168d/bazel-out/k8-opt/bin/pkg/sql/opt/norm/factory.og.go#L25960-L25962
https://github.com/cockroachdb/cockroach/blob/7b9d20d87208db1ac6c24b68b73c742eb9b1168d/bazel-out/k8-opt/bin/pkg/sql/opt/memo/expr.og.go#L9790-L9792

cockroach/pkg/sql/opt/memo/logical_props_builder.go

Lines 1582 to 1584 in 7b9d20d

func (b *logicalPropsBuilder) buildFiltersItemProps(item *FiltersItem, scalar *props.Scalar) {
BuildSharedProps(item.Condition, &scalar.Shared, b.evalCtx)

cockroach/pkg/sql/opt/memo/logical_props_builder.go

Lines 1789 to 1791 in 7b9d20d

} else {
BuildSharedProps(e.Child(i), shared, evalCtx)
}

cockroach/pkg/sql/opt/memo/logical_props_builder.go

Lines 1735 to 1737 in 7b9d20d

if !ok {
panic(errors.AssertionFailedf(
"comparison overload not found (%s, %s, %s)", e.Op(), leftType, rightType, 

src/runtime/asm_amd64.s in runtime.goexit at line 1650
pkg/sql/pgwire/server.go in pkg/sql/pgwire.(*Server).serveImpl.func3 at line 1002
pkg/sql/pgwire/conn.go in pkg/sql/pgwire.(*conn).processCommands at line 247
pkg/sql/conn_executor.go in pkg/sql.(*Server).ServeConn at line 969
pkg/sql/conn_executor.go in pkg/sql.(*connExecutor).run at line 2185
pkg/sql/conn_executor.go in pkg/sql.(*connExecutor).execCmd at line 2370
pkg/sql/conn_executor.go in pkg/sql.(*connExecutor).execCmd.func2 at line 2368
pkg/sql/conn_executor_exec.go in pkg/sql.(*connExecutor).execPortal at line 250
pkg/sql/conn_executor_exec.go in pkg/sql.(*connExecutor).execStmt at line 144
pkg/sql/conn_executor_exec.go in pkg/sql.(*connExecutor).execWithProfiling at line 3407
pkg/sql/conn_executor_exec.go in pkg/sql.(*connExecutor).execStmt.func1 at line 145
pkg/sql/conn_executor_exec.go in pkg/sql.(*connExecutor).execStmtInOpenState at line 1128
pkg/sql/conn_executor_exec.go in pkg/sql.(*connExecutor).dispatchToExecutionEngine at line 1763
pkg/sql/conn_executor_exec.go in pkg/sql.(*connExecutor).makeExecPlan at line 2291
pkg/sql/plan_opt.go in pkg/sql.(*planner).makeOptimizerPlan at line 245
pkg/sql/plan_opt.go in pkg/sql.(*optPlanningCtx).buildExecMemo at line 549
pkg/sql/plan_opt.go in pkg/sql.(*optPlanningCtx).reuseMemo at line 516
pkg/sql/opt/norm/factory.go in pkg/sql/opt/norm.(*Factory).AssignPlaceholders at line 389
pkg/sql/opt/norm/factory.go in pkg/sql/opt/norm.(*Factory).CopyAndReplace at line 324
bazel-out/k8-opt/bin/pkg/sql/opt/norm/factory.og.go in pkg/sql/opt/norm.(*Factory).invokeReplace at line 26014
pkg/sql/opt/norm/factory.go in pkg/sql/opt/norm.(*Factory).AssignPlaceholders.func2 at line 387
bazel-out/k8-opt/bin/pkg/sql/opt/norm/factory.og.go in pkg/sql/opt/norm.(*Factory).CopyAndReplaceDefault at line 24644
bazel-out/k8-opt/bin/pkg/sql/opt/norm/factory.og.go in pkg/sql/opt/norm.(*Factory).copyAndReplaceDefaultFiltersExpr at line 25961
bazel-out/k8-opt/bin/pkg/sql/opt/memo/expr.og.go in pkg/sql/opt/memo.(*FiltersItem).PopulateProps at line 9791
pkg/sql/opt/memo/logical_props_builder.go in pkg/sql/opt/memo.(*logicalPropsBuilder).buildFiltersItemProps at line 1583
pkg/sql/opt/memo/logical_props_builder.go in pkg/sql/opt/memo.BuildSharedProps at line 1790
pkg/sql/opt/memo/logical_props_builder.go in pkg/sql/opt/memo.BuildSharedProps at line 1736

Tags

Tag Value
Command server
Environment v23.2.10
Go Version go1.21.12 X:nocoverageredesign
Platform linux amd64
Distribution CCL
Cockroach Release v23.2.10
Cockroach SHA 7b9d20d
# of CPUs 12
# of Goroutines 544

Jira issue: CRDB-43449
@cockroach-sentry cockroach-sentry added branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-sentry Originated from an in-the-wild panic report. labels Oct 21, 2024
@yuzefovich yuzefovich added T-sql-queries SQL Queries Team X-blathers-triaged blathers was able to find an owner labels Nov 12, 2024
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Nov 12, 2024
@yuzefovich
Copy link
Member

dup of #132577 or #130399

@github-project-automation github-project-automation bot moved this from Triage to Done in SQL Queries Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-sentry Originated from an in-the-wild panic report. T-sql-queries SQL Queries Team X-blathers-triaged blathers was able to find an owner
Projects
SQL Queries
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yuzefovich @cockroach-sentry