sql: enable joins in bigtest

[RaduBerinde]

In light of #12033, it seems that we have gaps in our logic testing of joins.

We should enable joins in the bigtest:

cockroach/pkg/sql/logic_test.go

Line 1076 in 74032f1

// TODO(pmattis): We don't support joins.

[knz]

We tried that before - See #7733 and #7734.
We cannot reuse the existing test suite but we could extract salient pieces out of it.

[knz]

Suggested by @petermattis: go through the bigtest joins and collect those that work, and otherwise update the TODO in TestLogic.

[dianasaur323]

@asubiotto In your team notes re enabling bigtest with distsql, did we address this issue? If so, we can close. Otherwise, no action needed! Thanks.

[RaduBerinde]

No, this is about enabling more stuff inside bigtest (for both regular and distsql).

[jordanlewis]

I recently investigated adding some more of these, and we're pretty close. The main incompatibility seems to be our lack of support for integer division via INT / INT - for some reason this kind of expression shows up in nearly all of the un-enabled tests.

[dianasaur323]

Thanks both of you! In that case, I'm going to assign to you for now, @jordanlewis.

[jordanlewis]

There's too many in-the-weeds issues blocking this task to leave it a 1.0 priority. I'm still working on it but I don't want it to block other stuff before the release.

[jordanlewis]

These tests only test CROSS JOIN it turns out, and we can't run them because of random annoying incompatibilities like lack of unary + on strings. I think we should just close this.

[knz]

all right, but please then first update the TODO(s) to inform the reader of your conclusions.

[jordanlewis]

I've already updated the TODOs after my latest PR.