Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: test replicate queue behavior #11987

Closed
petermattis opened this issue Dec 4, 2016 · 4 comments
Closed

storage: test replicate queue behavior #11987

petermattis opened this issue Dec 4, 2016 · 4 comments
Labels
A-kv-replication Relating to Raft, consensus, and coordination. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. no-issue-activity T-kv KV Team X-stale

Comments

@petermattis
Copy link
Collaborator

#11982 fixed an issue where the replicate queue was retrying lease transfers for a range repeatedly because the available target replica was behind and thus not a candidate. The replicate queue code does not make testing this easy. We should either refactor it or create infrastructure to make such tests feasible.

@petermattis petermattis self-assigned this Dec 4, 2016
@petermattis petermattis added this to the Q1 2017 milestone Feb 23, 2017
@petermattis petermattis modified the milestones: Later, Q1 2017 Apr 6, 2017
@petermattis
Copy link
Collaborator Author

@a-robinson tossing your way as this likely ties in with other rebalancing work you're doing.

@tbg
Copy link
Member

tbg commented Jul 22, 2018

Is there anything left to do here?

@tbg tbg added the C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. label Jul 22, 2018
@a-robinson
Copy link
Contributor

Well, we're still missing the tests and test infrastructure for the replicate queue that were desired when the issue was created. I think it's fair to leave open, especially given that the purpose of the replicate queue is changing slightly as part of #26059

@petermattis petermattis removed this from the Later milestone Oct 5, 2018
@a-robinson a-robinson removed their assignment Jan 11, 2019
@github-actions
Copy link

github-actions bot commented Jun 9, 2021

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-kv-replication Relating to Raft, consensus, and coordination. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. no-issue-activity T-kv KV Team X-stale
Projects
None yet
Development

No branches or pull requests

4 participants