opt: v23.1.11: comparison overload not found (×, ×, ×): unredact operator and type names

[cockroach-sentry]

This issue was auto filed by Sentry. It represents a crash or reported error on a live cluster with telemetry enabled.

Sentry Link: https://cockroach-labs.sentry.io/issues/4775391687/?referrer=webhooks_plugin

Panic Message:

logical_props_builder.go:1682: comparison overload not found (×, ×, ×)
(1) assertion failure
Wraps: (2) attached stack trace
  -- stack trace:
  | github.com/cockroachdb/cockroach/pkg/sql/opt/memo.BuildSharedProps
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/memo/logical_props_builder.go:1682
  | github.com/cockroachdb/cockroach/pkg/sql/opt/memo.BuildSharedProps
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/memo/logical_props_builder.go:1733
  | github.com/cockroachdb/cockroach/pkg/sql/opt/memo.BuildSharedProps
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/memo/logical_props_builder.go:1733
  | github.com/cockroachdb/cockroach/pkg/sql/opt/memo.(*logicalPropsBuilder).buildFiltersItemProps
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/memo/logical_props_builder.go:1529
  | github.com/cockroachdb/cockroach/pkg/sql/opt/memo.(*FiltersItem).PopulateProps
  | 	github.com/cockroachdb/cockroach/bazel-out/k8-opt/bin/pkg/sql/opt/memo/expr.og.go:9299
  | github.com/cockroachdb/cockroach/pkg/sql/opt/norm.(*Factory).ConstructFiltersItem
  | 	github.com/cockroachdb/cockroach/bazel-out/k8-opt/bin/pkg/sql/opt/norm/factory.og.go:12834
  | github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder.(*Builder).buildWhere
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/select.go:1253
  | github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder.(*Builder).buildSelectClause
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/select.go:1124
  | github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder.(*Builder).buildSelectStmtWithoutParens
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/select.go:1069
  | github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder.(*Builder).buildSelect.func1
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/select.go:1038
  | github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder.(*Builder).processWiths
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/with.go:116
  | github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder.(*Builder).buildSelect
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/select.go:1037
  | github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder.(*Builder).buildStmt
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/builder.go:332
  | github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder.(*Builder).buildStmtAtRoot
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/builder.go:272
  | github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder.(*Builder).Build
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/builder.go:246
  | github.com/cockroachdb/cockroach/pkg/sql.(*optPlanningCtx).buildReusableMemo
  | 	github.com/cockroachdb/cockroach/pkg/sql/plan_opt.go:433
  | github.com/cockroachdb/cockroach/pkg/sql.(*planner).prepareUsingOptimizer
  | 	github.com/cockroachdb/cockroach/pkg/sql/plan_opt.go:164
  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).populatePrepared
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor_prepare.go:333
  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).prepare.func2
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor_prepare.go:271
  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).prepare
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor_prepare.go:276
  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).addPreparedStmt
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor_prepare.go:115
  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execPrepare
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor_prepare.go:76
  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execCmd
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2314
  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).run
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2105
  | github.com/cockroachdb/cockroach/pkg/sql.(*Server).ServeConn
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:902
  | github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).processCommandsAsync.func1
  | 	github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:310
  | runtime.goexit
  | 	GOROOT/src/runtime/asm_amd64.s:1594
Wraps: (3) comparison overload not found (×, ×, ×)
Error types: (1) *assert.withAssertionFailure (2) *withstack.withStack (3) *errutil.leafError
-- report composition:
*errutil.leafError: comparison overload not found (×, ×, ×)
logical_props_builder.go:1682: *withstack.withStack (top exception)
*assert.withAssertionFailure

Stacktrace (expand for inline code snippets):

GOROOT/src/runtime/asm_amd64.s#L1593-L1595

cockroach/pkg/sql/pgwire/conn.go

Lines 309 to 311 in 8d065df

	reservedOwned = false // We're about to pass ownership away.
	retErr = sqlServer.ServeConn(
	ctx,

cockroach/pkg/sql/conn_executor.go

Lines 901 to 903 in 8d065df

	}(ctx, h)
	return h.ex.run(ctx, s.pool, reserved, cancel)
	}

cockroach/pkg/sql/conn_executor.go

Lines 2104 to 2106 in 8d065df

	var err error
	if err = ex.execCmd(); err != nil {
	// Both of these errors are normal ways for the connExecutor to exit.

cockroach/pkg/sql/conn_executor.go

Lines 2313 to 2315 in 8d065df

	stmtCtx := withStatement(ctx, ex.curStmtAST)
	ev, payload = ex.execPrepare(stmtCtx, tcmd)
	case DescribeStmt:

cockroach/pkg/sql/conn_executor_prepare.go

Lines 75 to 77 in 8d065df

	stmt := makeStatement(parseCmd.Statement, ex.server.cfg.GenerateID())
	_, err := ex.addPreparedStmt(
	ctx,

cockroach/pkg/sql/conn_executor_prepare.go

Lines 114 to 116 in 8d065df

	// Prepare the query. This completes the typing of placeholders.
	prepared, err := ex.prepare(ctx, stmt, placeholderHints, rawTypeHints, origin)
	if err != nil {

cockroach/pkg/sql/conn_executor_prepare.go

Lines 275 to 277 in 8d065df

	// Use the existing transaction.
	if err := prepare(ctx, ex.state.mu.txn); err != nil {
	if origin != PreparedStatementOriginSessionMigration {

cockroach/pkg/sql/conn_executor_prepare.go

Lines 270 to 272 in 8d065df

	p.semaCtx.Annotations = tree.MakeAnnotations(stmt.NumAnnotations)
	flags, err = ex.populatePrepared(ctx, txn, placeholderHints, p, origin)
	return err

cockroach/pkg/sql/conn_executor_prepare.go

Lines 332 to 334 in 8d065df

	// and execute paths.
	flags, err := p.prepareUsingOptimizer(ctx)
	if err != nil {

cockroach/pkg/sql/plan_opt.go

Lines 163 to 165 in 8d065df

	memo, err := opc.buildReusableMemo(ctx)
	if err != nil {

cockroach/pkg/sql/plan_opt.go

Lines 432 to 434 in 8d065df

	bld.KeepPlaceholders = true
	if err := bld.Build(); err != nil {
	return nil, err

cockroach/pkg/sql/opt/optbuilder/builder.go

Lines 245 to 247 in 8d065df

	// and physical properties.
	outScope := b.buildStmtAtRoot(b.stmt, nil /* desiredTypes */)

cockroach/pkg/sql/opt/optbuilder/builder.go

Lines 271 to 273 in 8d065df

	b.ctes = nil
	outScope = b.buildStmt(stmt, desiredTypes, inScope)
	// Build With operators for any CTEs hoisted to the top level.

cockroach/pkg/sql/opt/optbuilder/builder.go

Lines 331 to 333 in 8d065df

	case *tree.Select:
	return b.buildSelect(stmt, noRowLocking, desiredTypes, inScope)

cockroach/pkg/sql/opt/optbuilder/select.go

Lines 1036 to 1038 in 8d065df

	return b.processWiths(with, inScope, func(inScope *scope) *scope {
	return b.buildSelectStmtWithoutParens(

cockroach/pkg/sql/opt/optbuilder/with.go

Lines 115 to 117 in 8d065df

	inScope.atRoot = false
	outScope := buildStmt(inScope)
	outScope.expr = b.buildWiths(outScope.expr, correlatedCTEs)

cockroach/pkg/sql/opt/optbuilder/select.go

Lines 1037 to 1039 in 8d065df

	return b.processWiths(with, inScope, func(inScope *scope) *scope {
	return b.buildSelectStmtWithoutParens(
	wrapped, orderBy, limit, locking, desiredTypes, inScope,

cockroach/pkg/sql/opt/optbuilder/select.go

Lines 1068 to 1070 in 8d065df

	case *tree.SelectClause:
	outScope = b.buildSelectClause(t, orderBy, locking, desiredTypes, inScope)

cockroach/pkg/sql/opt/optbuilder/select.go

Lines 1123 to 1125 in 8d065df

	b.processWindowDefs(sel, fromScope)
	b.buildWhere(sel.Where, fromScope)

cockroach/pkg/sql/opt/optbuilder/select.go

Lines 1252 to 1254 in 8d065df

	inScope.expr,
	memo.FiltersExpr{b.factory.ConstructFiltersItem(filter)},
	)

https://github.com/cockroachdb/cockroach/blob/8d065df26e25a762a1abbbf2b1e475456b341a00/bazel-out/k8-opt/bin/pkg/sql/opt/norm/factory.og.go#L12833-L12835
https://github.com/cockroachdb/cockroach/blob/8d065df26e25a762a1abbbf2b1e475456b341a00/bazel-out/k8-opt/bin/pkg/sql/opt/memo/expr.og.go#L9298-L9300

cockroach/pkg/sql/opt/memo/logical_props_builder.go

Lines 1528 to 1530 in 8d065df

	func (b *logicalPropsBuilder) buildFiltersItemProps(item *FiltersItem, scalar *props.Scalar) {
	BuildSharedProps(item.Condition, &scalar.Shared, b.evalCtx)

cockroach/pkg/sql/opt/memo/logical_props_builder.go

Lines 1732 to 1734 in 8d065df

	} else {
	BuildSharedProps(e.Child(i), shared, evalCtx)
	}

cockroach/pkg/sql/opt/memo/logical_props_builder.go

Lines 1732 to 1734 in 8d065df

	} else {
	BuildSharedProps(e.Child(i), shared, evalCtx)
	}

cockroach/pkg/sql/opt/memo/logical_props_builder.go

Lines 1681 to 1683 in 8d065df

	if !ok {
	panic(errors.AssertionFailedf(
	"comparison overload not found (%s, %s, %s)", e.Op(), leftType, rightType,

GOROOT/src/runtime/asm_amd64.s in runtime.goexit at line 1594
pkg/sql/pgwire/conn.go in pkg/sql/pgwire.(*conn).processCommandsAsync.func1 at line 310
pkg/sql/conn_executor.go in pkg/sql.(*Server).ServeConn at line 902
pkg/sql/conn_executor.go in pkg/sql.(*connExecutor).run at line 2105
pkg/sql/conn_executor.go in pkg/sql.(*connExecutor).execCmd at line 2314
pkg/sql/conn_executor_prepare.go in pkg/sql.(*connExecutor).execPrepare at line 76
pkg/sql/conn_executor_prepare.go in pkg/sql.(*connExecutor).addPreparedStmt at line 115
pkg/sql/conn_executor_prepare.go in pkg/sql.(*connExecutor).prepare at line 276
pkg/sql/conn_executor_prepare.go in pkg/sql.(*connExecutor).prepare.func2 at line 271
pkg/sql/conn_executor_prepare.go in pkg/sql.(*connExecutor).populatePrepared at line 333
pkg/sql/plan_opt.go in pkg/sql.(*planner).prepareUsingOptimizer at line 164
pkg/sql/plan_opt.go in pkg/sql.(*optPlanningCtx).buildReusableMemo at line 433
pkg/sql/opt/optbuilder/builder.go in pkg/sql/opt/optbuilder.(*Builder).Build at line 246
pkg/sql/opt/optbuilder/builder.go in pkg/sql/opt/optbuilder.(*Builder).buildStmtAtRoot at line 272
pkg/sql/opt/optbuilder/builder.go in pkg/sql/opt/optbuilder.(*Builder).buildStmt at line 332
pkg/sql/opt/optbuilder/select.go in pkg/sql/opt/optbuilder.(*Builder).buildSelect at line 1037
pkg/sql/opt/optbuilder/with.go in pkg/sql/opt/optbuilder.(*Builder).processWiths at line 116
pkg/sql/opt/optbuilder/select.go in pkg/sql/opt/optbuilder.(*Builder).buildSelect.func1 at line 1038
pkg/sql/opt/optbuilder/select.go in pkg/sql/opt/optbuilder.(*Builder).buildSelectStmtWithoutParens at line 1069
pkg/sql/opt/optbuilder/select.go in pkg/sql/opt/optbuilder.(*Builder).buildSelectClause at line 1124
pkg/sql/opt/optbuilder/select.go in pkg/sql/opt/optbuilder.(*Builder).buildWhere at line 1253
bazel-out/k8-opt/bin/pkg/sql/opt/norm/factory.og.go in pkg/sql/opt/norm.(*Factory).ConstructFiltersItem at line 12834
bazel-out/k8-opt/bin/pkg/sql/opt/memo/expr.og.go in pkg/sql/opt/memo.(*FiltersItem).PopulateProps at line 9299
pkg/sql/opt/memo/logical_props_builder.go in pkg/sql/opt/memo.(*logicalPropsBuilder).buildFiltersItemProps at line 1529
pkg/sql/opt/memo/logical_props_builder.go in pkg/sql/opt/memo.BuildSharedProps at line 1733
pkg/sql/opt/memo/logical_props_builder.go in pkg/sql/opt/memo.BuildSharedProps at line 1733
pkg/sql/opt/memo/logical_props_builder.go in pkg/sql/opt/memo.BuildSharedProps at line 1682

Tags

Tag	Value
Command	start-single-node
Environment	v23.1.13
Go Version	go1.19.13
Platform	linux amd64
Distribution	CCL
Cockroach Release	v23.1.13
Cockroach SHA	8d065df
# of CPUs	128
# of Goroutines	1193

Jira issue: CRDB-35018

[yuzefovich]

@michae2 another spot for unredacting type names is mentioned in #117484.

[yuzefovich]

We now have multiple reproductions of this issue (#132577, #130399, #128889, #94087, #83972), so I don't think we need to do this anymore.