Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streamingccl: cross version replication stream fails on crdb_internal.setup_span_configs_stream() #113682

Closed
adityamaru opened this issue Nov 2, 2023 · 2 comments · Fixed by #113703
Closed

streamingccl: cross version replication stream fails on crdb_internal.setup_span_configs_stream() #113682

adityamaru opened this issue Nov 2, 2023 · 2 comments · Fixed by #113703
Assignees
@adityamaru
Labels
A-disaster-recovery branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. GA-blocker O-testcluster Issues found or occurred on a test cluster, i.e. a long-running internal cluster P-0 Issues/test failures with a fix SLA of 2 weeks T-disaster-recovery

Comments

@adityamaru
Copy link
Contributor

adityamaru commented Nov 2, 2023 •
edited by cockroach-jira-scripts
Loading

In a test cluster replication from a 23.1.11 cluster to 23.2-alpha5 cluster, the stream failed with:

W231102 15:45:03.691584 587856 ccl/streamingccl/streamclient/span_config_stream_client.go:142 ⋮ [T1,Vsystem,n3,job=‹REPLICATION STREAM INGESTION id=913794457274843137›] 248
54  error when closing subscription connection: ‹ERROR: unknown function: crdb_internal.setup_span_configs_stream(): function undefined (SQLSTATE 42883)›

We should either add logic that informs the destination about the source cluster's version so that we can gate certain features. Or we should perform some error handling and prevent the stream from failing fatally.

Jira issue: CRDB-33108
@adityamaru adityamaru added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-disaster-recovery labels Nov 2, 2023
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Nov 2, 2023

cc @cockroachdb/disaster-recovery

@adityamaru adityamaru added GA-blocker branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 labels Nov 2, 2023
@adityamaru
Copy link
Contributor Author

this is a weak GA blocker considering the very limited use and availability of workarounds for users running PCR in 23.1. We can drop the tag if the fix takes longer than expected.

@ajstorm ajstorm added the O-testcluster Issues found or occurred on a test cluster, i.e. a long-running internal cluster label Nov 2, 2023
@adityamaru adityamaru mentioned this issue Nov 2, 2023
Merged
@craig craig bot closed this as completed in 194151c Nov 10, 2023
@blathers-crl blathers-crl bot mentioned this issue Nov 10, 2023
Merged
@ajstorm ajstorm added the P-0 Issues/test failures with a fix SLA of 2 weeks label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adityamaru adityamaru

Labels
A-disaster-recovery branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. GA-blocker O-testcluster Issues found or occurred on a test cluster, i.e. a long-running internal cluster P-0 Issues/test failures with a fix SLA of 2 weeks T-disaster-recovery
Projects
No open projects
Disaster Recovery Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

streamingccl: fix cross cluster replication bug adityamaru/cockroach
2 participants
@adityamaru @ajstorm