Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scplan: create scplan/internal/rules/release_23_2 #112571

Closed
Xiang-Gu opened this issue Oct 17, 2023 · 1 comment · Fixed by #113010
Closed

scplan: create scplan/internal/rules/release_23_2 #112571

Xiang-Gu opened this issue Oct 17, 2023 · 1 comment · Fixed by #113010
Assignees
@Xiang-Gu
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@Xiang-Gu
Copy link
Contributor

Xiang-Gu commented Oct 17, 2023 •
edited by cockroach-jira-scripts
Loading

The declarative schema changer maintains dep-rule between releases by grouping all rules present in each release in a separate directory. Now that branch release-23.2 is cut, we should create one for it on master.

Note: It's currently not doable as cluster version V24_1 does not exist yet on master

Jira issue: CRDB-32498
@Xiang-Gu Xiang-Gu added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Oct 17, 2023
@rafiss
Copy link
Collaborator

rafiss commented Oct 24, 2023

@Xiang-Gu the version should exist now, since #112271 was merged.

I believe resolving this issue should also resolve #112376.

@Xiang-Gu Xiang-Gu mentioned this issue Oct 24, 2023
Merged
@craig craig bot closed this as completed in f4d0c8b Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xiang-Gu Xiang-Gu

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
No open projects
SQL Foundations
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

scplan: Create rule/release_23_2 directory Xiang-Gu/cockroach
2 participants
@rafiss @Xiang-Gu