Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: tpch_concurrency failed #112178

Closed
cockroach-teamcity opened this issue Oct 11, 2023 · 2 comments · Fixed by #112339
Closed

roachtest: tpch_concurrency failed #112178

cockroach-teamcity opened this issue Oct 11, 2023 · 2 comments · Fixed by #112339
Assignees
Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team
Milestone

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Oct 11, 2023

roachtest.tpch_concurrency failed with artifacts on release-23.1 @ 30cd7fc605e1d05f4a37750806052625d7b9fae1:

(tpch_concurrency.go:194).func4: crashed 3 times out of 4 iterations (streamer enabled)
test artifacts and logs in: /artifacts/tpch_concurrency/run_1

Parameters: ROACHTEST_arch=amd64 , ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

Jira issue: CRDB-32277

@cockroach-teamcity cockroach-teamcity added branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team labels Oct 11, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Oct 11, 2023
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Oct 11, 2023
@yuzefovich
Copy link
Member

First run: n3 crashed soon after completing Q21 and while executing Q22 at 08:10:45. The last heap profile we have is from 08:05:28 during Q21. It accounts for roughly 4GiB of live memory usage, which is close to our --max-sql-memory. One of the biggest unaccounted for usages comes from kvcoord.(*condensableSpanSet), so this crash seems related to #81451. We probably won't add memory accounting here any time soon.

Second run: same story - n3 crashed right after Q21 at 10:19:27. The latest heap profile is even more stale, but it seems to be very similar.

Third run: n3 crashed soon after Q18 and while executing Q19 at 11:55:52. Heap profile is more than 30 minutes stale.

Fourth run: success.

This was with the streamer enabled, so perhaps #111921 would help a bit. Also perhaps #112338 would help with reducing the pressure on the GC.

In order to prevent further somewhat useless failures of this type, I'll lower the concurrency.

@cockroach-teamcity
Copy link
Member Author

roachtest.tpch_concurrency failed with artifacts on release-23.1 @ 366fe013b4b63bef98c953d03b302dc5e0b13ee7:

(tpch_concurrency.go:194).func4: crashed 3 times out of 4 iterations (streamer enabled)
test artifacts and logs in: /artifacts/tpch_concurrency/run_1

Parameters: ROACHTEST_arch=amd64 , ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

This test on roachdash | Improve this report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants