Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: verify that circuit breakers actually fail fast on dial #110553

Closed
erikgrinaker opened this issue Sep 13, 2023 · 1 comment · Fixed by #110891
Closed

rpc: verify that circuit breakers actually fail fast on dial #110553

erikgrinaker opened this issue Sep 13, 2023 · 1 comment · Fixed by #110891
Assignees
Labels
A-kv-replication Relating to Raft, consensus, and coordination. branch-master Failures and bugs on the master branch. GA-blocker O-premortem Issues identified during premortem exercise. O-qa

Comments

@erikgrinaker
Copy link
Contributor

erikgrinaker commented Sep 13, 2023

This comment seems to indicate that we don't actually enable the circuit breaker for dials, which would be surprising and bad. But the reference to getBreaker() is stale so it may just be an outdated comment. We should find out, and either fix the comment or revisit the breakers.

// NB: at the time of writing, we don't use the breaking capabilities,
// i.e. we don't check the circuit breaker in `Connect`. We will do that
// once the circuit breaker is mature, and then retire the breakers
// returned by Context.getBreaker.

Jira issue: CRDB-31501

@erikgrinaker erikgrinaker added O-qa A-kv-replication Relating to Raft, consensus, and coordination. branch-master Failures and bugs on the master branch. GA-blocker T-kv-replication O-premortem Issues identified during premortem exercise. labels Sep 13, 2023
@blathers-crl
Copy link

blathers-crl bot commented Sep 13, 2023

cc @cockroachdb/replication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-kv-replication Relating to Raft, consensus, and coordination. branch-master Failures and bugs on the master branch. GA-blocker O-premortem Issues identified during premortem exercise. O-qa
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant