Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver,allocator: overloaded store with no leases is unable to shed load #107704

Open
kvoli opened this issue Jul 27, 2023 · 0 comments
Open

kvserver,allocator: overloaded store with no leases is unable to shed load #107704

kvoli opened this issue Jul 27, 2023 · 0 comments
Labels
A-kv-distribution Relating to rebalancing and leasing. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-kv KV Team

Comments

@kvoli
Copy link
Collaborator

kvoli commented Jul 27, 2023

In #106140 we saw a hot node which couldn't shed any load at one point due to not having any leases i.e. follower overload.

The store rebalancer is responsible for helping relieve overload, however it only operates on ranges it has a lease for.

if !candidateReplica.OwnsValidLease(ctx, now) {
log.KvDistribution.VEventf(ctx, 3, "store doesn't own the lease for r%d", candidateReplica.GetRangeID())
continue
}

if !candidateReplica.OwnsValidLease(ctx, now) {
log.KvDistribution.VEventf(ctx, 3, "store doesn't own the lease for r%d", candidateReplica.GetRangeID())
continue
}

The replicate queue will balance the #replicas, however this store already had fewer replicas than others.

The result is, once in this state, the node will never shed sufficient load to stop being overloaded.

Jira issue: CRDB-30169

@kvoli kvoli added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-kv-distribution Relating to rebalancing and leasing. labels Jul 27, 2023
@blathers-crl blathers-crl bot added the T-kv KV Team label Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-kv-distribution Relating to rebalancing and leasing. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-kv KV Team
Projects
None yet
Development

No branches or pull requests

1 participant