Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose crdb_internal.invalid_objects inside the console UI #107568

Open
fqazi opened this issue Jul 25, 2023 · 1 comment
Open

Expose crdb_internal.invalid_objects inside the console UI #107568

fqazi opened this issue Jul 25, 2023 · 1 comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-observability ui-design-needed Issues that require a UX/UI design for it

Comments

@fqazi
Copy link
Collaborator

fqazi commented Jul 25, 2023

Is your feature request related to a problem? Please describe.
Clusters can potentially have descriptor corruption because of schema changer bugs, which can lead to upgrade issues
or inaccessible tables. Fortunately Cockroach DB has builtin diagnostics for these using the crdb_internal.invalid_objects table.

Describe the solution you'd like
We should periodically have the console scan crdb_internal.invalid_objects and have some type of notification for
database administration when descriptor issues are addressed. This will allow for administrators to be aware of
any potential upgrade issues earlier.

Describe alternatives you've considered

Additional context
This is important also in reference to a recent TA: https://www.cockroachlabs.com/docs/advisories/a99561 where this CRDB internal table now reports this problem

Jira issue: CRDB-30112

@fqazi fqazi added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-observability labels Jul 25, 2023
@maryliag maryliag added the ui-design-needed Issues that require a UX/UI design for it label Jul 26, 2023
@rafiss
Copy link
Collaborator

rafiss commented Aug 1, 2023

A related approach is the idea in #104266 (comment) -- we could add a metric that shows the size of the crdb_internal.invalid_objects table. It's possible that just showing the size alone is enough to be helpful, and if it's non-zero the customer can look at the table manually. If that's fine, we may not need to resolve this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-observability ui-design-needed Issues that require a UX/UI design for it
Projects
None yet
Development

No branches or pull requests

3 participants