Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/sql/schemachanger/schemachanger_test: TestValidateMixedVersionElements_alter_table_add_primary_key_drop_rowid failed #106406

Closed
cockroach-teamcity opened this issue Jul 7, 2023 · 1 comment
Closed

pkg/sql/schemachanger/schemachanger_test: TestValidateMixedVersionElements_alter_table_add_primary_key_drop_rowid failed #106406

cockroach-teamcity opened this issue Jul 7, 2023 · 1 comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Milestone
23.2

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jul 7, 2023 •
edited by cockroach-jira-scripts
Loading

pkg/sql/schemachanger/schemachanger_test.TestValidateMixedVersionElements_alter_table_add_primary_key_drop_rowid failed with artifacts on master @ c15e86aa1084b7845dc7608ef35361c7db09d84b:

        INSERT INTO t VALUES($stageKey);
        INSERT INTO t VALUES($stageKey + 1);
        ----
    datadriven.go:143: 
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/10824/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/schemachanger/schemachanger_test_/schemachanger_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/schemachanger/testdata/end_to_end/alter_table_add_primary_key_drop_rowid/alter_table_add_primary_key_drop_rowid.definition:12:
        stage-query [2 args]
        SELECT count(*)=$successfulStageCount*2 FROM t;
        ----
        true
    datadriven.go:143: 
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/10824/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/schemachanger/schemachanger_test_/schemachanger_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/schemachanger/testdata/end_to_end/alter_table_add_primary_key_drop_rowid/alter_table_add_primary_key_drop_rowid.definition:18:
        stage-exec [2 args]
        INSERT INTO t VALUES($stageKey);
        INSERT INTO t VALUES($stageKey + 1);
        ----
    datadriven.go:143: 
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/10824/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/schemachanger/schemachanger_test_/schemachanger_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/schemachanger/testdata/end_to_end/alter_table_add_primary_key_drop_rowid/alter_table_add_primary_key_drop_rowid.definition:25:
        stage-query [2 args]
        SELECT count(*)=$successfulStageCount*2 FROM t;
        ----
        true
=== RUN   TestValidateMixedVersionElements_alter_table_add_primary_key_drop_rowid/pause_upgrade_and_resume_at_each_stage
=== RUN   TestValidateMixedVersionElements_alter_table_add_primary_key_drop_rowid/pause_upgrade_and_resume_at_each_stage/PostCommitPhase_2_of_15
=== RUN   TestValidateMixedVersionElements_alter_table_add_primary_key_drop_rowid/pause_upgrade_and_resume_at_each_stage/PostCommitPhase_3_of_15
=== RUN   TestValidateMixedVersionElements_alter_table_add_primary_key_drop_rowid/pause_upgrade_and_resume_at_each_stage/PostCommitPhase_8_of_15
panic: Fail in goroutine after TestValidateMixedVersionElements_alter_table_add_primary_key_drop_rowid/pause_upgrade_and_resume_at_each_stage/PostCommitPhase_5_of_15 has completed

goroutine 312695 [running]:
testing.(*common).Fail(0x4005aafd40)
	GOROOT/src/testing/testing.go:824 +0xd0
testing.(*common).Errorf(0x4005aafd40, {0x47a3ddd?, 0x4005aafd40?}, {0x400c6aa040?, 0x4?, 0x46bc700?})
	GOROOT/src/testing/testing.go:941 +0x60
github.com/stretchr/testify/assert.Fail({0x5b5fb20, 0x4005aafd40}, {0x400a740000, 0x64}, {0x0, 0x0, 0x0})
	github.com/stretchr/testify/assert/external/com_github_stretchr_testify/assert/assertions.go:333 +0x2fc
github.com/stretchr/testify/assert.NoError({0x5b5fb20, 0x4005aafd40}, {0x5b5f3e0, 0x400c3b2000}, {0x0, 0x0, 0x0})
	github.com/stretchr/testify/assert/external/com_github_stretchr_testify/assert/assertions.go:1495 +0xd0
github.com/stretchr/testify/require.NoError({0x5b73a50, 0x4005aafd40}, {0x5b5f3e0, 0x400c3b2000}, {0x0, 0x0, 0x0})
	github.com/stretchr/testify/require/external/com_github_stretchr_testify/require/require.go:1357 +0x8c
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/sctest.ValidateMixedVersionElements.func5.1.2()
	github.com/cockroachdb/cockroach/pkg/sql/schemachanger/sctest/cumulative.go:1724 +0x254
created by github.com/cockroachdb/cockroach/pkg/sql/schemachanger/sctest.ValidateMixedVersionElements.func5.1
	github.com/cockroachdb/cockroach/pkg/sql/schemachanger/sctest/cumulative.go:1715 +0x274
=== RUN   TestValidateMixedVersionElements_alter_table_add_primary_key_drop_rowid/pause_upgrade_and_resume_at_each_stage/PostCommitPhase_1_of_15
=== RUN   TestValidateMixedVersionElements_alter_table_add_primary_key_drop_rowid/pause_upgrade_and_resume_at_each_stage/PostCommitPhase_4_of_15
    skip.go:190: skipping due to randomness
=== RUN   TestValidateMixedVersionElements_alter_table_add_primary_key_drop_rowid/pause_upgrade_and_resume_at_each_stage/PostCommitPhase_5_of_15
=== RUN   TestValidateMixedVersionElements_alter_table_add_primary_key_drop_rowid/pause_upgrade_and_resume_at_each_stage/PostCommitPhase_6_of_15
    skip.go:190: skipping due to randomness
=== RUN   TestValidateMixedVersionElements_alter_table_add_primary_key_drop_rowid/pause_upgrade_and_resume_at_each_stage/PostCommitPhase_7_of_15
    skip.go:190: skipping due to randomness
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-foundations

This test on roachdash | Improve this report!

Jira issue: CRDB-29556
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Jul 7, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.2 milestone Jul 7, 2023
@rafiss
Copy link
Collaborator

rafiss commented Jul 7, 2023

We can't repro since after #106411 was merged.

@rafiss rafiss closed this as completed Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
23.2
Development

No branches or pull requests
2 participants
@rafiss @cockroach-teamcity