From 03a6d4a69403f9ec6ebbfdae1eddf0c9fbd7d5b7 Mon Sep 17 00:00:00 2001 From: Nathan VanBenschoten Date: Thu, 12 Nov 2020 17:54:37 -0500 Subject: [PATCH] kv: remove assertion around QuotaPool and Raft window size config This check was well intentioned when added, but seems misguided in retrospect. There are valid reasons why someone might want to configure limits to various dimensions of the Raft window size in ways that, when combined, exceeds the total window size limit (i.e. the quota pool size). --- pkg/base/config.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/pkg/base/config.go b/pkg/base/config.go index fdef1a9ee61d..60df6b33696b 100644 --- a/pkg/base/config.go +++ b/pkg/base/config.go @@ -413,9 +413,6 @@ func (cfg *RaftConfig) SetDefaults() { if cfg.RaftProposalQuota > int64(cfg.RaftMaxUncommittedEntriesSize) { panic("raft proposal quota should not be above max uncommitted entries size") } - if cfg.RaftProposalQuota < int64(cfg.RaftMaxSizePerMsg)*int64(cfg.RaftMaxInflightMsgs) { - panic("raft proposal quota should not be below per-replica replication window size") - } } // RaftElectionTimeout returns the raft election timeout, as computed from the