Empty state tables should not show headings

[garrett]

Example in the accounts page:

Originally posted by @garrett in #20763 (comment)

I'm not sure if other parts of Cockpit have headings when tables have empty states. Many (most? all other?) other places to not.

[Niketiiitd]

Could you please resend the image? I’m unable to open it.

[garrett]

That was posted in the summer of 2024; I work with a lot of graphics. I don't know which one it would be, if I even still have it locally. It seems like it was a screenshot, which could've even been pasted directly from capturing it, forgoing a save to disk (you can copy from Firefox screenshots and paste into GitHub).

I don't know why GitHub dropped the image from both here and in the PR. Sorry. It seems like they had a bug in storage somehow.

But the context is that empty state tables should never have headings.

Here's a screenshot of the accounts page, with a filter searching for "example" which doesn't match a user on my system, and the empty state has a heading... and it shouldn't. I would guess the missing screenshot probably looked like this:

It should look something like this quickly modified version of the screenshot:

[Mash707]

Hi @garrett I would like to explore this issue. I think account-list.js is the right place to work on.
Do you have any other important information that could help with this issue?
Thank You.

[jelly]

This requires some more non-trivial work with larger implications, that page and other pages use a ListingTable with an emptyComponent set, which doesn't draw headers when there are no rows. Changing that would change everything which uses a ListingTable

[Mash707]

Should I try to do a workaround for this or leave it for now?

[jelly]

@Mash707 I think we want to change this for all tables if I understood @garrett correctly.

[Mash707]

@jelly I'll try to make some changes locally to test things out and see what happens. I'll let you know once I have some updates

[garrett]

I think we want to change this for all tables if I understood garrett correctly.

Yes, it should generally be like this for all tables.