Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome --no-sandbox flag #606

Closed
eggnita opened this issue Apr 24, 2018 · 3 comments
Closed

Chrome --no-sandbox flag #606

eggnita opened this issue Apr 24, 2018 · 3 comments
Milestone

Comments

@eggnita
Copy link

eggnita commented Apr 24, 2018

It seems that in the latest versions of Chrome you cannot start without --no-sandbox flag in environments like Docker. This issue appears in other common CI tools like travis (which already got an updated chrome version in the build environment images)
You can see more details here
I can PR this if needed.
The place where this option should be added is:
eggnita/splinter@d54fecf

This can also be fixed by handling #345

@andrewsmedina
Copy link
Member

I believe that we should merge #345

@eggnita
Copy link
Author

eggnita commented Apr 26, 2018

@andrewsmedina can I help with the merge? or do you have any idea when that can be merged? Because it seems that the removal of the headless param and the addition of the chrome_options will introduce some breaking changes. What are your thoughts regarding this?

@andrewsmedina
Copy link
Member

The PR #345 needs tests. I would be nice if you can help adding tests for this pr.

@andrewsmedina andrewsmedina modified the milestones: 1.0, 0.9 May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants