Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate this project into the main server #44

Open
SchoolGuy opened this issue Sep 13, 2022 · 0 comments
Open

Integrate this project into the main server #44

SchoolGuy opened this issue Sep 13, 2022 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@SchoolGuy
Copy link
Member

As a developer
I want be able to not maintain duplicated code in relation to distro_signatures.json
so that I can take advantage of the advanced functionality of this library in the main server.


Some remarks for this issue:

  • If there are changes required to this library to make access for consumers of the library easier, let's discuss it and do it, we haven't tagged anything yet
  • The CLI of this library needs to be mature enough to work with existing distro_signatures.json files
  • The serialization for the server items we need to adjust since that is at the moment storing the strings for the versions. If we switch to the DAO (data access objects) here, then we need to be careful with serialization and the XML-RPC API.

My idea for the timeline is the following:

  • This project is being integrated into the main server codebase in a pre-release (let's say something alike 0.1.0)
  • We test everything before a Cobbler release
  • We iterate the first two points before this one until we are happy with the results
  • We tag 1.0.0 for this library
  • We upgrade the Cobbler dependency to 1.0.0
  • We release Cobbler with the integrated library

Code usages I was able to identify:

Additionally the CLI has some usages but we ignore those as we will not put effort into a deprecated CLI. The effort needs to be put into the Golang CLI. This CLI can be progressed as soon as cobbler/cobbler#3164 (with PR cobbler/cobbler#3244) is fixed (merged) and we have merged cobbler/cobblerclient#10 on the CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant