Make code examples on homepage bookmarkable #285
Conversation
|
I'm not sure about scrolling to the code example. Assume that someone chooses some language, scrolls up and than bookmarks the URL. In that case it would be strange if after clicking the bookmarked link the page would scroll to the code example. |
| @@ -5,7 +5,8 @@ var app = angular.module('coala', ['ngStorage','ngRoute', 'ngSanitize', 'btford. | |||
| $locationProvider.hashPrefix('') | |||
| $routeProvider. | |||
| when('/home', { | |||
| template: '<home></home>' | |||
| template: '<home></home>', | |||
| reloadOnSearch: false | |||
There was a problem hiding this comment.
@jayvdb , it would not work without this comma
There was a problem hiding this comment.
You need to add a trailing comma here.
|
@gitmate-bot rebase |
|
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
Add lang parameter to the URL Fixes coala#277
jayvdb
force-pushed
the
bookmarkable_example
branch
from
ad7449f to
adbadda
Compare
|
Automated rebase with GitMate.io was successful! 🎉 |
|
ack adbadda |
|
@gitmate-bot ff |
|
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently |
|
Automated fastforward with GitMate.io was successful! 🎉 |
Add lang parameter to the URL
Fixes #277
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
cobot mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!