Glob_Patterns.rst/Install.rst/Tutorial.rst: Fix external links which point to internal pages #596

Gromy1211 · 2019-02-10T16:42:08Z

This changes direct links to relative links to the internal page.

Closes #595

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

I read the commit guidelines and I've followed
them.
I ran coala over my code locally. (All commits have to pass
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

pick up any PR at https://coala.io/review
review it (check https://coala.io/reviewing for more info)
if you are sure that it needs work, use corobo mark wip <URL> to get it out
of the review queue.

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

gitmate-bot · 2019-02-10T16:43:38Z

Users/Install.rst

@@ -341,7 +341,7 @@ Shell-Autocompletion Support
 ----------------------------

 If you are a bash/zsh user , checkout the
-`guide <https://docs.coala.io/en/latest/Users/Shell_Autocompletion.html>`_
+:doc:`guide <Shell_Autocompletion>` 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: docs.

The issue can be fixed by applying the following patch:

--- a/tmp/tmphdwrkohi/Users/Install.rst +++ b/tmp/tmphdwrkohi/Users/Install.rst @@ -341,7 +341,7 @@ ---------------------------- If you are a bash/zsh user , checkout the -:doc:`guide <Shell_Autocompletion>` +:doc:`guide <Shell_Autocompletion>` to set up autocompletion for coala arguments and bear names.

gitmate-bot · 2019-02-10T16:58:57Z

Users/Install.rst

@@ -341,7 +341,7 @@ Shell-Autocompletion Support
 ----------------------------

 If you are a bash/zsh user , checkout the
-`guide <https://docs.coala.io/en/latest/Users/Shell_Autocompletion.html>`_
+:doc:`guide <Shell_Autocompletion>` 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: docs.

The issue can be fixed by applying the following patch:

--- a/tmp/tmphdwrkohi/Users/Install.rst +++ b/tmp/tmphdwrkohi/Users/Install.rst @@ -341,7 +341,7 @@ ---------------------------- If you are a bash/zsh user , checkout the -:doc:`guide <Shell_Autocompletion>` +:doc:`guide <Shell_Autocompletion>` to set up autocompletion for coala arguments and bear names.

li-boxuan · 2019-02-11T06:50:22Z

Users/Tutorial.rst

@@ -42,7 +42,7 @@ Command Line Interface

 In order to specify the files to analyze, you can use the ``--files``
 argument of coala like demonstrated below. For all file paths, you can
-specify (recursive) `globs <../Users/Glob_Patterns.html>`__.
+specify (recursive) :doc:`globs <Glob_Patterns>`  .


Redundant whitespace at the end of the sentence.

gitmate-bot · 2019-02-11T13:15:21Z

Users/Install.rst

@@ -341,7 +341,7 @@ Shell-Autocompletion Support
 ----------------------------

 If you are a bash/zsh user , checkout the
-`guide <https://docs.coala.io/en/latest/Users/Shell_Autocompletion.html>`_
+:doc:`guide <Shell_Autocompletion>` 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: docs.

The issue can be fixed by applying the following patch:

--- a/tmp/tmphdwrkohi/Users/Install.rst +++ b/tmp/tmphdwrkohi/Users/Install.rst @@ -341,7 +341,7 @@ ---------------------------- If you are a bash/zsh user , checkout the -:doc:`guide <Shell_Autocompletion>` +:doc:`guide <Shell_Autocompletion>` to set up autocompletion for coala arguments and bear names.

Users/Glob_Patterns.rst

areebbeigh

Good going 👍 you'll want to go through the commit guidelines.

Ideally, this PR should have only 1 commit for a small change. Your extra commits were made to resolve issues in your first commit. Take a look at squashing commits. You'll want to keep the first commit.

gitmate-bot · 2019-02-12T11:39:21Z

Users/Install.rst

@@ -341,7 +341,7 @@ Shell-Autocompletion Support
 ----------------------------

 If you are a bash/zsh user , checkout the
-`guide <https://docs.coala.io/en/latest/Users/Shell_Autocompletion.html>`_
+:doc:`guide <Shell_Autocompletion>` 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: docs.

The issue can be fixed by applying the following patch:

--- a/tmp/tmphdwrkohi/Users/Install.rst +++ b/tmp/tmphdwrkohi/Users/Install.rst @@ -341,7 +341,7 @@ ---------------------------- If you are a bash/zsh user , checkout the -:doc:`guide <Shell_Autocompletion>` +:doc:`guide <Shell_Autocompletion>` to set up autocompletion for coala arguments and bear names.

@Gromy1211 There is an extra space at the end of line. Remove it to get you PR error free

I think I have already removed the space, I don't know why gitmate-bot mentions it.

Ok, will see this. Ok Please squash your commits as well as make your heading small of upto 50 characters

Checkout
#596 (review)

Thanks a lot! I am working on the commits ;)

KVGarg · 2019-02-12T12:17:10Z

Also, you need to squash your commits.

gitmate-bot · 2019-02-12T13:44:33Z

Users/Install.rst

@@ -341,7 +341,7 @@ Shell-Autocompletion Support
 ----------------------------

 If you are a bash/zsh user , checkout the
-`guide <https://docs.coala.io/en/latest/Users/Shell_Autocompletion.html>`_
+:doc:`guide <Shell_Autocompletion>` 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: docs.

The issue can be fixed by applying the following patch:

--- a/tmp/tmphdwrkohi/Users/Install.rst +++ b/tmp/tmphdwrkohi/Users/Install.rst @@ -341,7 +341,7 @@ ---------------------------- If you are a bash/zsh user , checkout the -:doc:`guide <Shell_Autocompletion>` +:doc:`guide <Shell_Autocompletion>` to set up autocompletion for coala arguments and bear names.

gitmate-bot · 2019-02-12T14:11:34Z

Users/Install.rst

@@ -341,7 +341,7 @@ Shell-Autocompletion Support
 ----------------------------

 If you are a bash/zsh user , checkout the
-`guide <https://docs.coala.io/en/latest/Users/Shell_Autocompletion.html>`_
+:doc:`guide <Shell_Autocompletion>` 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: docs.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp05cyw6zo/Users/Install.rst +++ b/tmp/tmp05cyw6zo/Users/Install.rst @@ -341,7 +341,7 @@ ---------------------------- If you are a bash/zsh user , checkout the -:doc:`guide <Shell_Autocompletion>` +:doc:`guide <Shell_Autocompletion>` to set up autocompletion for coala arguments and bear names.

gitmate-bot · 2019-02-12T14:27:52Z

Users/Install.rst

@@ -341,7 +341,7 @@ Shell-Autocompletion Support
 ----------------------------

 If you are a bash/zsh user , checkout the
-`guide <https://docs.coala.io/en/latest/Users/Shell_Autocompletion.html>`_
+:doc:`guide <Shell_Autocompletion>` 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: docs.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp6inmy2l3/Users/Install.rst +++ b/tmp/tmp6inmy2l3/Users/Install.rst @@ -341,7 +341,7 @@ ---------------------------- If you are a bash/zsh user , checkout the -:doc:`guide <Shell_Autocompletion>` +:doc:`guide <Shell_Autocompletion>` to set up autocompletion for coala arguments and bear names.

This changes direct links to relative links to the internal page. Glob_Patterns.rst,Install.rst and Tutorial.rst are changed. Closes coala#595

TravisBuddy · 2019-02-12T15:24:49Z

Travis tests have failed

Hey @Gromy1211,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 439a88a0-2eda-11e9-9ea4-33062c9ac3a7

jayvdb · 2019-02-14T00:22:41Z

ack 218b9d3

jayvdb · 2019-02-14T00:22:49Z

@gitmate-bot ff

gitmate-bot · 2019-02-14T00:22:52Z

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

gitmate-bot · 2019-02-14T00:23:54Z

Automated fastforward with GitMate.io was successful! 🎉

gitmate-bot added process/pending review size/XS area/sphinx difficulty/newcomer labels Feb 10, 2019

gitmate-bot assigned Gromy1211 Feb 10, 2019

gitmate-bot reviewed Feb 10, 2019

View reviewed changes

li-boxuan requested changes Feb 11, 2019

View reviewed changes

li-boxuan added process/wip and removed process/pending review labels Feb 11, 2019

gitmate-bot added process/pending review and removed process/wip labels Feb 11, 2019

gitmate-bot reviewed Feb 11, 2019

View reviewed changes

areebbeigh suggested changes Feb 12, 2019

View reviewed changes

Users/Glob_Patterns.rst Outdated Show resolved Hide resolved

areebbeigh reviewed Feb 12, 2019

View reviewed changes

gitmate-bot reviewed Feb 12, 2019

View reviewed changes

Gromy1211 force-pushed the master branch from faa6c25 to 1d0c88d Compare February 12, 2019 13:43

gitmate-bot reviewed Feb 12, 2019

View reviewed changes

Gromy1211 force-pushed the master branch from 1d0c88d to adaeac8 Compare February 12, 2019 14:09

gitmate-bot reviewed Feb 12, 2019

View reviewed changes

Gromy1211 force-pushed the master branch from adaeac8 to 242ca80 Compare February 12, 2019 14:25

gitmate-bot reviewed Feb 12, 2019

View reviewed changes

Link: Fix external links

218b9d3

This changes direct links to relative links to the internal page. Glob_Patterns.rst,Install.rst and Tutorial.rst are changed. Closes coala#595

Gromy1211 force-pushed the master branch from 242ca80 to 218b9d3 Compare February 12, 2019 15:16

gitmate-bot added process/approved and removed process/pending review labels Feb 14, 2019

gitmate-bot merged commit 218b9d3 into coala:master Feb 14, 2019

gitmate-bot removed the process/approved label Feb 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Glob_Patterns.rst/Install.rst/Tutorial.rst: Fix external links which point to internal pages #596

Glob_Patterns.rst/Install.rst/Tutorial.rst: Fix external links which point to internal pages #596

Gromy1211 commented Feb 10, 2019

gitmate-bot Feb 10, 2019

gitmate-bot Feb 10, 2019

li-boxuan Feb 11, 2019

gitmate-bot Feb 11, 2019

areebbeigh left a comment •

edited

Loading

gitmate-bot Feb 12, 2019

KVGarg Feb 12, 2019

Gromy1211 Feb 12, 2019

KVGarg Feb 12, 2019

KVGarg Feb 12, 2019 •

edited

Loading

Gromy1211 Feb 12, 2019

KVGarg commented Feb 12, 2019 •

edited

Loading

gitmate-bot Feb 12, 2019

gitmate-bot Feb 12, 2019

gitmate-bot Feb 12, 2019

TravisBuddy commented Feb 12, 2019

jayvdb commented Feb 14, 2019

jayvdb commented Feb 14, 2019

gitmate-bot commented Feb 14, 2019

gitmate-bot commented Feb 14, 2019

Glob_Patterns.rst/Install.rst/Tutorial.rst: Fix external links which point to internal pages #596

Glob_Patterns.rst/Install.rst/Tutorial.rst: Fix external links which point to internal pages #596

Conversation

Gromy1211 commented Feb 10, 2019

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

areebbeigh left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KVGarg Feb 12, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KVGarg commented Feb 12, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TravisBuddy commented Feb 12, 2019

Travis tests have failed

TravisBuddy Request Identifier: 439a88a0-2eda-11e9-9ea4-33062c9ac3a7

jayvdb commented Feb 14, 2019

jayvdb commented Feb 14, 2019

gitmate-bot commented Feb 14, 2019

gitmate-bot commented Feb 14, 2019

areebbeigh left a comment •

edited

Loading

KVGarg Feb 12, 2019 •

edited

Loading

KVGarg commented Feb 12, 2019 •

edited

Loading