Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Review Docs #529

Closed
nemani opened this issue Feb 12, 2018 · 4 comments · Fixed by coala/coala#5200
Closed

Update Review Docs #529

nemani opened this issue Feb 12, 2018 · 4 comments · Fixed by coala/coala#5200

Comments

@nemani
Copy link
Member

nemani commented Feb 12, 2018

http://api.coala.io/en/latest/Developers/Review.html

A lot of policy has been changed, that has not been reflected in the docs.
The ones I know of currently are:
[ ] Ack is now supposed to be done by maintainers only, other should use "Looks good" or "LGTM" (Lets get this merged)
[ ] We are not using rultor anymore.

@himanshu1603
Copy link

@nemaniarjun can I take up this issue?

@nemani
Copy link
Member Author

nemani commented Feb 15, 2018

Sure a maintainer will be here to assign you soon, or ask on gitter :)

@Makman2
Copy link
Member

Makman2 commented Feb 15, 2018

Please accept the org invite @himanshu1603 , then you can be assigned.

@monsij
Copy link

monsij commented Feb 20, 2018

Can I be assigned this issue @Makman2 due to user inactivity?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

5 participants