Fixed `codeblock` error 😉 #501

0x48piraj · 2017-11-26T01:27:53Z

Fixes #499 👍

Changes made :-

Added :: 😊

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

I read the commit guidelines and I've followed
them.
I ran coala over my code locally. (All commits have to pass
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

pick up any PR at https://coala.io/review
review it (check https://coala.io/reviewing for more info)
if you are sure that it needs work, use cobot mark wip <URL> to get it out
of the review queue.

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

`::` was missing 😊

khanchi97 · 2017-11-26T03:15:23Z

Users/coafile.rst

@@ -93,7 +93,7 @@ This is the same file without section inheritance::
 All settings must be part of a section, so don't do this for implicit
 inheritance (this is also deprecated behavior). Implicit inheritance
 was leading to a section automatically getting inherited to all other
-sections without semantically making sense.
+sections without semantically making sense.::


@0x48piraj Remove trailing period, then it will look fine 👍

But, everywhere the same pattern is followed.

Yeah, that's what I'm saying, everywhere the pattern should be same.But in your case, it should be like this
sections without semantically making sense::

There's a full-stop at the last of sentence, so I left it. Should I remove the full-stop ? 😊

yes, that's what I'm talking about.

yes, and it should look like this making sense:

No @khanchi97 , making sense: reverts the whole issue back to zero 😉

And, making sense:: does - making sense.:
I think my first commit was OK. 😊

If you code like this making sense:: then it will look like making sense: that you have done already.Now you only have to squash your commits 👍

I am sorry, But I'm on Web Interface, I will take care from the next time ! 😕
A maintainer can merge and squash the commits easily.

Reference : https://stackoverflow.com/questions/35948131/github-squash-commits-from-web-interface-on-pull-request-after-review-comments

khanchi97 · 2017-11-26T05:33:03Z

You also have to squash your commits.If you don't know how to squash commits then follow this link http://api.coala.io/en/latest/Developers/Git_Basics.html#squashing-your-commits

prnvdixit · 2017-11-26T05:35:07Z

Also, fix your commit to adhere to https://coala.io/commit 😄

0x48piraj · 2017-11-26T05:58:16Z

I am sorry, But I'm on Web Interface, I will take care from the next time ! 😕
A maintainer can merge and squash the commits easily.

Reference : https://stackoverflow.com/questions/35948131/github-squash-commits-from-web-interface-on-pull-request-after-review-comments

jayvdb · 2017-11-27T05:39:21Z

@0x48piraj, please follow the instructions given to you by our developers. We have good reasons for why and how we do things, which you will learn if you proceed through the newcomer process.
Our newcomer process exists only to ensure you know how to use git correctly.
If you dont follow our processes, we discard your PR.
Thank you.

0x48piraj · 2017-11-27T06:11:27Z

Okay, I will do it all again 👍
But, I think you should have given me a chance, I said I will take care from next time.
I know how to use git, It's just that, the issue was so small that I used web-interface.

If you dont follow our processes, we discard your PR.

I never said anything @jayvdb , It was just a request.
Sorry. 😖

prnvdixit · 2017-11-27T06:35:26Z

@0x48piraj

I think you should have given me a chance

You are still assigned to the issue - Nobody would or can take up a issue from you unless you are not working on it anymore. 🎉
As far as using web interface is concerned - We all (and hopefully you too) contribute to OSS to get familiar with ideal practices both for actual coding as well as code management. So, preferably you should respond firmly to any reviews (or critical comments) rather than "I never said anything" 😉.
You might get away with using web interface for some of your issues but at the end of day, you might have to move to git to solve some complex ones - So, why not use it from start itself 😛.

I will do it all again

Also, it's a great first PR 😄 - you needn't start a new PR, just go through the suggested changes and associated guides 😃.

0x48piraj · 2017-11-27T06:48:31Z

Also, it's a great first PR 😄 - you needn't start a new PR, just go through the suggested changes and associated guides 😃.

I was talking about setting up the project in git 😛
And "I never said anything" was for that this was just a request to accept this PR, and from next issue, I will do it via git.
Anyways, you all are right! I read the guidelines, but of my laziness I did it via web-interface.
I know I'm assigned 😉
Thanks @prnvdixit for such a positive comment.
From now, I will do as it is done in coala 😊

newbazz

You have three commits for the same issue, this sud not be the case one commit for each issue as per the newcomers guide. So kindly squash your commits to one.

newbazz

Always use 'git commit --amend' after the first commit

newbazz · 2018-01-06T03:19:16Z

@0x48piraj are you still on this issue?

0x48piraj · 2018-01-06T03:28:31Z

Actually No.
If they'll merge it as it is. Cool! Otherwise, You can work on this 👍

newbazz · 2018-01-06T03:31:13Z

Sorry, but it cant be merged as it is.

0x48piraj · 2018-01-06T03:34:33Z

🤣 Okay @newbazz. Go on 🚀

Fixed codeblock error 😉

9e4db35

`::` was missing 😊

gitmate-bot added process/pending review size/XS labels Nov 26, 2017

indentation fix

3c08271

khanchi97 suggested changes Nov 26, 2017

View reviewed changes

co-robo added process/wip and removed process/pending review labels Nov 26, 2017

removed full-stop

1bc7ba6

gitmate-bot added the process/pending review label Nov 26, 2017

co-robo removed the process/wip label Nov 26, 2017

jayvdb added process/wip and removed process/pending review labels Nov 27, 2017

newbazz suggested changes Nov 29, 2017

View reviewed changes

gitmate-bot added the status/stale label Dec 7, 2017

newbazz suggested changes Dec 12, 2017

View reviewed changes

0x48piraj closed this Jan 6, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed `codeblock` error 😉 #501

Fixed `codeblock` error 😉 #501

0x48piraj commented Nov 26, 2017

khanchi97 Nov 26, 2017

0x48piraj Nov 26, 2017

khanchi97 Nov 26, 2017

0x48piraj Nov 26, 2017

khanchi97 Nov 26, 2017

khanchi97 Nov 26, 2017

0x48piraj Nov 26, 2017

0x48piraj Nov 26, 2017 •

edited

Loading

khanchi97 Nov 26, 2017

0x48piraj Nov 26, 2017

khanchi97 commented Nov 26, 2017

prnvdixit commented Nov 26, 2017

0x48piraj commented Nov 26, 2017

jayvdb commented Nov 27, 2017

0x48piraj commented Nov 27, 2017 •

edited

Loading

prnvdixit commented Nov 27, 2017

0x48piraj commented Nov 27, 2017

newbazz left a comment

newbazz left a comment

newbazz commented Jan 6, 2018

0x48piraj commented Jan 6, 2018

newbazz commented Jan 6, 2018

0x48piraj commented Jan 6, 2018

Fixed codeblock error 😉 #501

Fixed codeblock error 😉 #501

Conversation

0x48piraj commented Nov 26, 2017

Fixes #499 👍

Changes made :-

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0x48piraj Nov 26, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

khanchi97 commented Nov 26, 2017

prnvdixit commented Nov 26, 2017

0x48piraj commented Nov 26, 2017

jayvdb commented Nov 27, 2017

0x48piraj commented Nov 27, 2017 • edited Loading

prnvdixit commented Nov 27, 2017

0x48piraj commented Nov 27, 2017

newbazz left a comment

Choose a reason for hiding this comment

newbazz left a comment

Choose a reason for hiding this comment

newbazz commented Jan 6, 2018

0x48piraj commented Jan 6, 2018

newbazz commented Jan 6, 2018

0x48piraj commented Jan 6, 2018

Fixed `codeblock` error 😉 #501

Fixed `codeblock` error 😉 #501

0x48piraj Nov 26, 2017 •

edited

Loading

0x48piraj commented Nov 27, 2017 •

edited

Loading