-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.coafile: Add YAMLLintBear #186
Conversation
.travis.yml
Outdated
rm bears/haskell/GhcModBear.py tests/haskell/GhcModBearTest.py; | ||
rm -r bears/verilog tests/verilog/; | ||
rm | ||
bears/c_languages/CSharpLintBear.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add indentation for arguments , so that it is easy to see where the next command starts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sure.
Can someone help me to pass ci/dockercloud? I don't know what breaks it. Thanks |
I'm so sorry. I miss clicked the button. Instead of "Comment," I clicked "Close and comment" |
@lherman-cs , can you rebase this patch (see the guides in our dev docs for how-to) |
.travis.yml
Outdated
set -e -x; | ||
/work/pytest.sh; | ||
/work/vcs.sh; | ||
======= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax error: could not find expected ':'
YAMLLintBear, severity MAJOR, section yml
.
Hi @lherman-cs , to rebase properly, you should archive your current branch , to a name like |
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
2 similar comments
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
Add YAMLLintBear to .coafile and fix .travis.yml issues raised by coala Closes coala#183
Thanks, @jayvdb. I've fixed all the issues you mentioned before. |
8b207ea
to
9adb1d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check comments.
|
||
[yml] | ||
bears = YAMLLintBear | ||
files = *.yml, hooks/*.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a new line at file end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add LineLengthBear
too.
and better change [yml]
to [YAML]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lherman-cs Please make changes as requested by other reviewers.
Also, squash your commits into one.
Add YAMLLintBear to .coafile and
fix .travis.yml issues raised by coala
Closes #183