Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue warning whenever someone is mentioned using @ if the target is not a member of the org #317

Open
co-robo opened this issue Oct 28, 2017 · 6 comments

Comments

@co-robo
Copy link

co-robo commented Oct 28, 2017

difficulty/low initiative/gci
Opened by @jayvdb at gitter/coala/coala

@RaiVaibhav
Copy link
Member

I will try to look on this issue

@prnvdixit
Copy link
Member

@RaiVaibhav This is also a GCI issue 😉 (See description)

@RaiVaibhav
Copy link
Member

Oh it added in last i think

@jayvdb
Copy link
Member

jayvdb commented Aug 5, 2018

Note this also has a security aspect to it, as it ensures there is checking happening on any username mentioned, which can prevent mistakes in process due to incorrect username being used, and allow mistakes to be fixed quickly.

@jayvdb
Copy link
Member

jayvdb commented Aug 5, 2018

The one command where this shouldnt happen is the LabHub invite command, as the mentioned username should not be a member of the org

@nvzard
Copy link
Member

nvzard commented Aug 5, 2018

This has been already taken care of in the invite command with the use of is_room_member method. I'll create a callback message to issue a warning if the mentioned user is not a member of the room.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

7 participants