From 7676c2fd9462983e3eb37a692092f4af8aecb2e0 Mon Sep 17 00:00:00 2001
From: Lucifer24 <divyeshpuri66@gmail.com>
Date: Sat, 18 Nov 2017 14:48:40 -0800
Subject: [PATCH]  .coafile: Add section for XML files

Added section for XML files, also
fixed issues raised by XMLBear.

Closes https://github.com/coala/coala-eclipse/issues/39
---
 .coafile                      |  4 ++
 com.coala.core.tests/pom.xml  |  3 +-
 com.coala.core/plugin.xml     | 72 +++++++++--------------------------
 com.coala.core/pom.xml        |  3 +-
 com.coala.feature/feature.xml | 13 +------
 com.coala.feature/pom.xml     |  3 +-
 com.coala.site/pom.xml        |  3 +-
 7 files changed, 27 insertions(+), 74 deletions(-)

diff --git a/.coafile b/.coafile
index 5374be4..83060d2 100644
--- a/.coafile
+++ b/.coafile
@@ -5,3 +5,7 @@ ignore = com.coala.core/src/com/coala/core/utils/diff_match_patch.java
 bears = CheckstyleBear
 max_line_length = 90
 use_spaces = True
+
+[xml]
+files = **/*.xml
+bears = XMLBear
diff --git a/com.coala.core.tests/pom.xml b/com.coala.core.tests/pom.xml
index 2e688c1..b8df10b 100644
--- a/com.coala.core.tests/pom.xml
+++ b/com.coala.core.tests/pom.xml
@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
   <modelVersion>4.0.0</modelVersion>
 
   <parent>
diff --git a/com.coala.core/plugin.xml b/com.coala.core/plugin.xml
index 335ad3d..3159eaa 100644
--- a/com.coala.core/plugin.xml
+++ b/com.coala.core/plugin.xml
@@ -2,43 +2,22 @@
 <?eclipse version="3.4"?>
 <plugin>
 
-   <extension
-         point="org.eclipse.ui.commands">
-      <category
-            name="Main Category"
-            id="com.coala.core.commands.category">
+   <extension point="org.eclipse.ui.commands">
+      <category name="Main Category" id="com.coala.core.commands.category">
       </category>
-      <command
-            categoryId="com.coala.core.commands.category"
-            id="com.coala.core.commands.runcoalaCommand"
-            name="Run coala Command">
+      <command categoryId="com.coala.core.commands.category" id="com.coala.core.commands.runcoalaCommand" name="Run coala Command">
       </command>
-      <command
-            categoryId="com.coala.core.commands.category"
-            id="com.coala.core.commands.removeMarkersCommand"
-            name="Remove Markers Command">
+      <command categoryId="com.coala.core.commands.category" id="com.coala.core.commands.removeMarkersCommand" name="Remove Markers Command">
       </command>
-      <command
-            categoryId="com.coala.core.commands.category"
-            id="com.coala.core.commands.bearList"
-            name="Bears">
-         <commandParameter
-               id="com.coala.core.commands.bearList.parameters"
-               name="Bear List"
-               optional="false"
-               values="com.coala.core.menu.BearMenu">
+      <command categoryId="com.coala.core.commands.category" id="com.coala.core.commands.bearList" name="Bears">
+         <commandParameter id="com.coala.core.commands.bearList.parameters" name="Bear List" optional="false" values="com.coala.core.menu.BearMenu">
          </commandParameter>
       </command>
    </extension> 
-   <extension
-         point="org.eclipse.ui.handlers">
-      <handler
-            commandId="com.coala.core.commands.runcoalaCommand"
-            class="com.coala.core.handlers.RuncoafileHandler">
+   <extension point="org.eclipse.ui.handlers">
+      <handler commandId="com.coala.core.commands.runcoalaCommand" class="com.coala.core.handlers.RuncoafileHandler">
       </handler>
-      <handler
-            commandId="com.coala.core.commands.removeMarkersCommand"
-            class="com.coala.core.handlers.RemoveMarkers">
+      <handler commandId="com.coala.core.commands.removeMarkersCommand" class="com.coala.core.handlers.RemoveMarkers">
       </handler>
    </extension>
    <!--
@@ -52,31 +31,16 @@
       </key>
    </extension>
    -->
-   <extension
-         point="org.eclipse.ui.menus">
-      <menuContribution
-            locationURI="popup:org.eclipse.ui.popup.any?after=additions">
-         <menu
-               icon="icons/coala-analyzer.gif"
-               id="com.coala.core.menus.popupMenu"
-               label="Run coala with"
-               mnemonic="o">
-            <dynamic
-              	  class="com.coala.core.menu.BearMenu"
-              	  id="com.coala.core.menu.bearListValues">
+   <extension point="org.eclipse.ui.menus">
+      <menuContribution locationURI="popup:org.eclipse.ui.popup.any?after=additions">
+         <menu icon="icons/coala-analyzer.gif" id="com.coala.core.menus.popupMenu" label="Run coala with" mnemonic="o">
+            <dynamic class="com.coala.core.menu.BearMenu" id="com.coala.core.menu.bearListValues">
    			</dynamic>
          </menu>
       </menuContribution>
-      <menuContribution
-            locationURI="toolbar:org.eclipse.ui.main.toolbar?after=additions">
-         <toolbar
-               id="com.coala.core.toolbar">
-            <command
-                  commandId="com.coala.core.commands.runcoalaCommand"
-                  icon="icons/coala-analyzer.gif"
-                  label="coala"
-                  mode="FORCE_TEXT"
-                  tooltip="Run coala on Project">
+      <menuContribution locationURI="toolbar:org.eclipse.ui.main.toolbar?after=additions">
+         <toolbar id="com.coala.core.toolbar">
+            <command commandId="com.coala.core.commands.runcoalaCommand" icon="icons/coala-analyzer.gif" label="coala" mode="FORCE_TEXT" tooltip="Run coala on Project">
             </command>
          </toolbar>
       </menuContribution>
@@ -91,9 +55,7 @@
 	</extension>
 	
 	<extension point="org.eclipse.ui.ide.markerResolution">
-      <markerResolutionGenerator
-         markerType="com.coala.core.problem"
-         class="com.coala.core.quickfix.QuickFixer"/>
+      <markerResolutionGenerator markerType="com.coala.core.problem" class="com.coala.core.quickfix.QuickFixer"/>
    </extension>
 	
    
diff --git a/com.coala.core/pom.xml b/com.coala.core/pom.xml
index e783005..f018a2b 100644
--- a/com.coala.core/pom.xml
+++ b/com.coala.core/pom.xml
@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
   <modelVersion>4.0.0</modelVersion>
 
   <parent>
diff --git a/com.coala.feature/feature.xml b/com.coala.feature/feature.xml
index e9b8e0c..c7e27ba 100644
--- a/com.coala.feature/feature.xml
+++ b/com.coala.feature/feature.xml
@@ -1,9 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<feature
-      id="com.coala.feature"
-      label="Feature"
-      version="1.0.0.qualifier"
-      provider-name="coala">
+<feature id="com.coala.feature" label="Feature" version="1.0.0.qualifier" provider-name="coala">
 
    <description url="http://coala-analyzer.org/">
       The coala Eclipse plug-in provides static code analysis using coala.
@@ -14,11 +10,6 @@ Visit http://coala-analyzer.org/ for more information.
       This program and the accompanying materials are made available under the terms of the AGPL License v3.
    </license>
 
-   <plugin
-         id="com.coala.core"
-         download-size="0"
-         install-size="0"
-         version="0.0.0"
-         unpack="false"/>
+   <plugin id="com.coala.core" download-size="0" install-size="0" version="0.0.0" unpack="false"/>
 
 </feature>
diff --git a/com.coala.feature/pom.xml b/com.coala.feature/pom.xml
index bc6a67a..070a740 100644
--- a/com.coala.feature/pom.xml
+++ b/com.coala.feature/pom.xml
@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
   <modelVersion>4.0.0</modelVersion>
 
   <parent>
diff --git a/com.coala.site/pom.xml b/com.coala.site/pom.xml
index eb84ab0..ef1b7ab 100644
--- a/com.coala.site/pom.xml
+++ b/com.coala.site/pom.xml
@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
   <modelVersion>4.0.0</modelVersion>
 
   <parent>