Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.coafile: Add section for XML files #41

Closed
wants to merge 1 commit into from
Closed

.coafile: Add section for XML files #41

wants to merge 1 commit into from

Conversation

DivyeshPuri
Copy link

Added section for XML files, also
fixed issues raised by XMLBear.

Closes #39

prashant0598
prashant0598 approved these changes Nov 18, 2017
View reviewed changes
Copy link
Member

@prashant0598 prashant0598 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but Travis is not fixed so pr will be blocked

@DivyeshPuri
.coafile: Add section for XML files
7676c2f 
Added section for XML files, also
fixed issues raised by XMLBear.

Closes coala#39
@aashutoshrathi
Copy link
Member

Why are files other than .coafile are changed?

@prashant0598
Copy link
Member

@aashutoshrathi i thk he has also used spaceconsistency bear 😄

@prashant0598
Copy link
Member

ack 7676c2f

@DivyeshPuri
Copy link
Author

@aashutoshrathi @prashant0598 i just ran XMLBear on my machine and it made the changes which was required for it to run.

yashovardhan
yashovardhan suggested changes Nov 19, 2017
View reviewed changes
Copy link
Member

@yashovardhan yashovardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you had to just add the section in .coafile in a commit

changing other files should go in a different commit I feel.

@Makman2
Copy link
Member

Makman2 commented Feb 8, 2018

Closing due to inactivity.

@Makman2 Makman2 closed this Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashovardhan yashovardhan yashovardhan requested changes

@prashant0598 prashant0598 prashant0598 approved these changes

Assignees

@DivyeshPuri DivyeshPuri

Labels
difficulty/low process/pending review size/S status/STALE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add XMLBear in .coafile
6 participants
@DivyeshPuri @aashutoshrathi @prashant0598 @Makman2 @yashovardhan @gitmate-bot