Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate_bear_requirements: Don't exit with 0 on error #1550

Open
coala-bot opened this issue Mar 27, 2017 · 2 comments
Open

generate_bear_requirements: Don't exit with 0 on error #1550

coala-bot opened this issue Mar 27, 2017 · 2 comments
Assignees
@nemani
Labels
difficulty/medium importance/low

Comments

@coala-bot
Copy link

coala-bot commented Mar 27, 2017 •
edited by jayvdb
Loading

See build https://travis-ci.org/coala/coala-bears/jobs/215563097#L3509 and especially #L3789 , where StyleLintBear reported errors which were ignored.

Opened via gitter by @Makman2
@jayvdb
Copy link
Member

jayvdb commented Mar 27, 2017

We have the git diff --exit-code as a safety net in the CI, so this is low priority.

@jayvdb
Copy link
Member

jayvdb commented Jul 20, 2018

And now we dont need to use git diff --exit-code due to arg --check being added as part of #2446 for #2444

However a failure to load a bear should be an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nemani nemani

Labels
difficulty/medium importance/low
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jayvdb @Makman2 @gitmate-bot @nemani @coala-bot