Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radon depends on flake8 #1388

Open
jayvdb opened this issue Feb 2, 2017 · 5 comments
Open

radon depends on flake8 #1388

jayvdb opened this issue Feb 2, 2017 · 5 comments

Comments

@jayvdb
Copy link
Member

jayvdb commented Feb 2, 2017

See #1228 (comment) for background on why this is a problem.

@jayvdb
Copy link
Member Author

jayvdb commented Feb 13, 2017

Mostly note to self: A non-upstream approach might be create a dummy (empty) flake8 package with an appropriate version to workaround the dependency requirements. In a virtualenv, this would be fine. However in a real environment, it would conflict with, and break, existing flake8, so a lot of care would be needed to ensure that it isnt possible for setuptools or pip to upgrade a proper flake8 with our dummy flake8 package (a magic envvar might be an option).

@jack17529

This comment has been minimized.

@jayvdb
Copy link
Member Author

jayvdb commented Nov 3, 2018

The temporary solution in 00103fe involved pinning radon to 1.4.0 .

radon is now 2.4.0

radon 1.4.0 is https://github.com/rubik/radon/tree/c1a100e13d , depends on colorama>=0.3,<0.4 , which is now becoming a big problem as many other packages depend on colorama >= 0.4.

@jayvdb
Copy link
Member Author

jayvdb commented Nov 3, 2018

radon current setup.py still depends on 'colorama>=0.3,<0.4', 'flake8-polyfill',

So both the flake8 problem and the colorama problem exist. Upgrading the dependency will not solve anything.

@jayvdb
Copy link
Member Author

jayvdb commented Nov 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants